Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:3535 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 43304 invoked from network); 21 Jul 2003 04:24:53 -0000 Received: from unknown (HELO mail.zend.com) (192.117.235.230) by pb1.pair.com with SMTP; 21 Jul 2003 04:24:53 -0000 Received: (qmail 25155 invoked from network); 21 Jul 2003 04:24:51 -0000 Received: from localhost (HELO andi-home.zend.com) (127.0.0.1) by localhost with SMTP; 21 Jul 2003 04:24:51 -0000 Message-ID: <5.1.0.14.2.20030721072637.042cc408@127.0.0.1> X-Sender: andi@127.0.0.1 X-Mailer: QUALCOMM Windows Eudora Version 5.1 Date: Mon, 21 Jul 2003 07:28:47 +0200 To: George Schlossnagle ,internals@lists.php.net In-Reply-To: <69AEA874-BB26-11D7-90A4-000393B2B3C0@omniti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: Re: [PHP-DEV] static property setters From: andi@zend.com (Andi Gutmans) References: <69AEA874-BB26-11D7-90A4-000393B2B3C0@omniti.com> Hey, Actually I think it's better to just have ZEND_DEFINE_PROPERTY() and pass those flags as an argument. There's no added value in having all the possible permutations such as ZEND_PRIVATE_PROPERTY(), ZEND_PROTECTED_PROPERTY(), ZEND_PUBLIC_PROPERTY() and so on.. We're not really saving any typing here. I can't remember who commited it (and it might even be with my consent) but thinking of it now I think it should be reverted. Andi At 10:52 PM 20/7/2003 -0400, George Schlossnagle wrote: >Andi, Zeev, > >Mind if I add > >#define ZEND_STATIC_PUBLIC_PROPERTY(class_ptr, name, value) > \ >{ > > \ > char *_name = (name); > >\ > int namelen = strlen(_name); > \ > zend_declare_property(class_ptr, _name, namelen, value, > ZEND_ACC_PUBLIC | ZEND_ACC_STATIC); \ >} > >macros to accomany the ZEND_*_PROPERTY macros? > >George > >-- George Schlossnagle >-- Principal Consultant >-- OmniTI Computer Consulting, Inc. >-- +1.410.872.4910 x202 >-- 1024D/1100A5A0 1370 F70A 9365 96C9 2F5E 56C2 B2B9 262F 1100 A5A0 > > >-- >PHP Internals - PHP Runtime Development Mailing List >To unsubscribe, visit: http://www.php.net/unsub.php