Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:35319 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 21356 invoked by uid 1010); 8 Feb 2008 12:17:57 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 21341 invoked from network); 8 Feb 2008 12:17:57 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Feb 2008 12:17:57 -0000 Authentication-Results: pb1.pair.com smtp.mail=jani.taskinen@sci.fi; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=jani.taskinen@sci.fi; sender-id=unknown Received-SPF: error (pb1.pair.com: domain sci.fi from 63.208.196.178 cause and error) X-PHP-List-Original-Sender: jani.taskinen@sci.fi X-Host-Fingerprint: 63.208.196.178 mho-01-bos.mailhop.org Received: from [63.208.196.178] ([63.208.196.178:52108] helo=mho-01-bos.mailhop.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 82/85-04488-5784CA74 for ; Fri, 08 Feb 2008 07:17:57 -0500 Received: from [81.22.163.71] (helo=[10.6.109.198]) by mho-01-bos.mailhop.org with esmtpsa (SSLv3:RC4-MD5:128) (Exim 4.68) (envelope-from ) id 1JNSB0-000KH8-Q4; Fri, 08 Feb 2008 12:17:55 +0000 X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 81.22.163.71 X-Report-Abuse-To: abuse@dyndns.com (see http://www.mailhop.org/outbound/abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+TKPNYW4Tq3h5ud+CPSiZsQa12CFmaixE= Reply-To: jani.taskinen@iki.fi To: Larry Garfield Cc: internals@lists.php.net In-Reply-To: <200802072332.01301.larry@garfieldtech.com> References: <200802072332.01301.larry@garfieldtech.com> Content-Type: text/plain Date: Fri, 08 Feb 2008 14:17:52 +0200 Message-ID: <1202473072.4246.4.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.8.3 (2.8.3-2.fc6) Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision From: jani.taskinen@sci.fi (Jani Taskinen) On Thu, 2008-02-07 at 23:32 -0600, Larry Garfield wrote: > On Thursday 07 February 2008, Lukas Kahwe Smith wrote: > > On 07.02.2008, at 00:59, Pierre Joye wrote: > > > Hi Andi, > > > > > > On Feb 7, 2008 12:56 AM, Andi Gutmans wrote: > > >> -1 > > >> > > >> Suggestion to enhance the suggestion: return false + emit E_STRICT > > >> message (but I am also fine with pure return false if people don't > > >> like > > >> this suggestion). > > > > > > Sounds reasonable too. It would be nice to add a deprecate notice in > > > 5.3.x as well. > > > > Yeah, note that we sort of agreed to split off an E_DEPRECATED from > > E_STRICT in PHP 5.3. > > > > regards, > > Lukas > > But in PHP 5.x, a well-written program should still be checking for magic > quotes so that it can undo the damage they cause if necessary. Not all > programs can control their environment, so checking those functions is > basically required if you want to run on a server over which you don't have > absolute control. I wouldn't say that's deprecated or a strict-violation. > > So I guess I'm -1: Restore them, always return false, and throw E_DEPRECATED. But this was about them being in PHP 6, not PHP 5.. If magic_quotes_* is gone, so should anything else even remotely related to them be gone. You have to fix your code anyway for it to work in PHP 6 (or even 5) without magic_crap.. --Jani -- Patches/Donations: http://pecl.php.net/~jani/