Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:35318 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 43640 invoked by uid 1010); 8 Feb 2008 06:24:11 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 43623 invoked from network); 8 Feb 2008 06:24:11 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Feb 2008 06:24:11 -0000 Authentication-Results: pb1.pair.com smtp.mail=tokul@users.sourceforge.net; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=tokul@users.sourceforge.net; sender-id=unknown Received-SPF: error (pb1.pair.com: domain users.sourceforge.net from 213.197.162.99 cause and error) X-PHP-List-Original-Sender: tokul@users.sourceforge.net X-Host-Fingerprint: 213.197.162.99 avilys.eik.lt Linux 2.6 Received: from [213.197.162.99] ([213.197.162.99:42278] helo=avilys.eik.lt) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 5E/78-16023-985FBA74 for ; Fri, 08 Feb 2008 01:24:10 -0500 Received: from avilys.eik.lt (avilys.local [127.0.0.1]) by avilys.eik.lt (Postfix) with ESMTP id 0FA352488F2 for ; Fri, 8 Feb 2008 08:19:13 +0200 (EET) Received: from avilys.eik.lt (avilys.local [127.0.0.1]) by avilys.eik.lt (Postfix) with ESMTP id E8AB02488F0 for ; Fri, 8 Feb 2008 08:19:12 +0200 (EET) Received: from 195.22.180.233 (NaSMail authenticated user tomas@topolis.lt) by avilys.eik.lt with HTTP; Fri, 8 Feb 2008 08:19:12 +0200 (EET) Message-ID: <51705.195.22.180.233.1202451552.nsm@avilys.eik.lt> In-Reply-To: <200802072332.01301.larry@garfieldtech.com> References: <200802072332.01301.larry@garfieldtech.com> Date: Fri, 8 Feb 2008 08:19:12 +0200 (EET) To: internals@lists.php.net User-Agent: NaSMail/1.4 MIME-Version: 1.0 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-Virus-Scanned: ClamAV using ClamSMTP Subject: Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision From: tokul@users.sourceforge.net ("Tomas Kuliavas") > On Thursday 07 February 2008, Lukas Kahwe Smith wrote: >> On 07.02.2008, at 00:59, Pierre Joye wrote: >> > Hi Andi, >> > >> > On Feb 7, 2008 12:56 AM, Andi Gutmans wrote: >> >> -1 >> >> >> >> Suggestion to enhance the suggestion: return false + emit E_STRICT >> >> message (but I am also fine with pure return false if people don't >> >> like >> >> this suggestion). >> > >> > Sounds reasonable too. It would be nice to add a deprecate notice in >> > 5.3.x as well. >> >> Yeah, note that we sort of agreed to split off an E_DEPRECATED from >> E_STRICT in PHP 5.3. >> >> regards, >> Lukas > > But in PHP 5.x, a well-written program should still be checking for magic > quotes so that it can undo the damage they cause if necessary. Not all > programs can control their environment, so checking those functions is > basically required if you want to run on a server over which you don't > have absolute control. -if (get_magic_quotes_gpc()) { +if (function_exists('get_magic_quotes_gpc') && get_magic_quotes_gpc()) {