Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:35308 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 94562 invoked by uid 1010); 7 Feb 2008 16:38:18 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 94547 invoked from network); 7 Feb 2008 16:38:18 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Feb 2008 16:38:18 -0000 Authentication-Results: pb1.pair.com header.from=dmitry@zend.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=dmitry@zend.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender) X-PHP-List-Original-Sender: dmitry@zend.com X-Host-Fingerprint: 212.25.124.162 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from [212.25.124.162] ([212.25.124.162:49223] helo=mail.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 8B/E1-10179-9F33BA74 for ; Thu, 07 Feb 2008 11:38:18 -0500 Received: (qmail 32445 invoked from network); 7 Feb 2008 16:38:14 -0000 Received: from unknown (HELO ?10.1.20.2?) (10.1.20.2) by mail.zend.net with SMTP; 7 Feb 2008 16:38:14 -0000 Message-ID: <47AB33F0.6070309@zend.com> Date: Thu, 07 Feb 2008 19:38:08 +0300 User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: Solar Designer CC: Sara Golemon , Stanislav Malyshev , Andi Gutmans , PHP Internals List References: <20071209010552.GA12561@openwall.com> <47A849D0.8050508@zend.com> <20080205235055.GA19309@openwall.com> <47AAD95A.8010109@zend.com> <20080207112109.GA30558@openwall.com> <20080207115027.GA30811@openwall.com> <20080207121353.GA11906@openwall.com> <47AB05CB.8010906@zend.com> <20080207135336.GA21239@openwall.com> In-Reply-To: <20080207135336.GA21239@openwall.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: untie the MD4 code from MD5 & replace the MD5 code From: dmitry@zend.com (Dmitry Stogov) Hi, Solar Designer wrote: > On Thu, Feb 07, 2008 at 04:21:15PM +0300, Dmitry Stogov wrote: >> I assume now the patch is ready to commit. >> I'll commit it tomorrow in case of no objections. > > Yes, it is. No objections from me. > > Just two minor points: > > 1. You have not yet fixed the size_t vs. php_uint32 issue in > PHP_MD5Final(), leaving it inconsistent with PHP_MD5Update(). This > should not affect correctness of the code, but it's just weird. According to algorithm "used" and "free" in PHP_MD5Final cannot be more than 64, so I don't see any reason for unnecessary conversions. Looking more careful I think they must be changed into php_uint32 in PHP_MD5Update too. > 2. The way you have re-formatted my comments still looks weird to me. ops. sorry for that. I'll put them in proper place before commit. Thanks. Dmitry. > Thanks, > > Alexander