Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:35299 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 5599 invoked by uid 1010); 7 Feb 2008 14:01:01 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 5584 invoked from network); 7 Feb 2008 14:01:01 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Feb 2008 14:01:01 -0000 Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 66.249.82.224 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 66.249.82.224 wx-out-0506.google.com Received: from [66.249.82.224] ([66.249.82.224:28942] helo=wx-out-0506.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 1F/62-10179-A1F0BA74 for ; Thu, 07 Feb 2008 09:00:59 -0500 Received: by wx-out-0506.google.com with SMTP id s14so3897425wxc.26 for ; Thu, 07 Feb 2008 06:00:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=mxZKv4Mq2S4B0G5/bEIpWIP1LwYwInU824ENBVHXNUA=; b=a1kldQFhpGf800xCaTECa+uHgiMujc7473LuDLxcvKfHxf9jkU3+fCMA4TgJfbnau8ewzFvaQbru7J7xyF+LdlYd1RXOSDjPi+xOJfSJWOrURC9XMyd6XEGMjI1J21syLYAcbgT5Jx1HtIdsG7zSncxiAqsoXlGlGBrtEO59SR4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Wl8/5baUx593CzvVev8GMaOSLNosTO06WLrThabWf+0zhB3bFMzO/QTYfe1WnxgyuHWFgdQXTUTYxV8TnhKgwk1k8ibqKpn2KHWInBTOnH+pMy9hlevWJajdGbO7iySYLnrfM7Z6xXz9zMUy+OlP6o5lJ0AWwBu3dd7lLmzXkCs= Received: by 10.141.122.20 with SMTP id z20mr7555233rvm.160.1202392855486; Thu, 07 Feb 2008 06:00:55 -0800 (PST) Received: by 10.141.70.21 with HTTP; Thu, 7 Feb 2008 06:00:55 -0800 (PST) Message-ID: Date: Thu, 7 Feb 2008 15:00:55 +0100 To: "Solar Designer" Cc: "Dmitry Stogov" , "Sara Golemon" , "Stanislav Malyshev" , "Andi Gutmans" , "PHP Internals List" In-Reply-To: <20080207135336.GA21239@openwall.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20071209010552.GA12561@openwall.com> <47A849D0.8050508@zend.com> <20080205235055.GA19309@openwall.com> <47AAD95A.8010109@zend.com> <20080207112109.GA30558@openwall.com> <20080207115027.GA30811@openwall.com> <20080207121353.GA11906@openwall.com> <47AB05CB.8010906@zend.com> <20080207135336.GA21239@openwall.com> Subject: Re: [PHP-DEV] Re: untie the MD4 code from MD5 & replace the MD5 code From: pierre.php@gmail.com ("Pierre Joye") Hi! Nice addition but can you please try to keep on thread for the discussions? Thanks :-) On Feb 7, 2008 2:53 PM, Solar Designer wrote: > On Thu, Feb 07, 2008 at 04:21:15PM +0300, Dmitry Stogov wrote: > > I assume now the patch is ready to commit. > > I'll commit it tomorrow in case of no objections. > > Yes, it is. No objections from me. > > Just two minor points: > > 1. You have not yet fixed the size_t vs. php_uint32 issue in > PHP_MD5Final(), leaving it inconsistent with PHP_MD5Update(). This > should not affect correctness of the code, but it's just weird. > > 2. The way you have re-formatted my comments still looks weird to me. > > Thanks, > > Alexander > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Pierre http://blog.thepimp.net | http://www.libgd.org