Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:35298 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 3474 invoked by uid 1010); 7 Feb 2008 13:58:33 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 3459 invoked from network); 7 Feb 2008 13:58:33 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Feb 2008 13:58:33 -0000 Authentication-Results: pb1.pair.com header.from=solar@openwall.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=solar@openwall.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain openwall.com designates 195.42.179.200 as permitted sender) X-PHP-List-Original-Sender: solar@openwall.com X-Host-Fingerprint: 195.42.179.200 mother.openwall.net Received: from [195.42.179.200] ([195.42.179.200:3751] helo=mother.openwall.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 6B/12-10179-88E0BA74 for ; Thu, 07 Feb 2008 08:58:32 -0500 Received: (qmail 26485 invoked from network); 7 Feb 2008 13:58:29 -0000 Received: from localhost (HELO pvt.openwall.com) (127.0.0.1) by localhost with SMTP; 7 Feb 2008 13:58:29 -0000 Received: by pvt.openwall.com (Postfix, from userid 503) id 14A912FD0E; Thu, 7 Feb 2008 16:53:36 +0300 (MSK) Date: Thu, 7 Feb 2008 16:53:36 +0300 To: Dmitry Stogov Cc: Sara Golemon , Stanislav Malyshev , Andi Gutmans , PHP Internals List Message-ID: <20080207135336.GA21239@openwall.com> References: <20071209010552.GA12561@openwall.com> <47A849D0.8050508@zend.com> <20080205235055.GA19309@openwall.com> <47AAD95A.8010109@zend.com> <20080207112109.GA30558@openwall.com> <20080207115027.GA30811@openwall.com> <20080207121353.GA11906@openwall.com> <47AB05CB.8010906@zend.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47AB05CB.8010906@zend.com> User-Agent: Mutt/1.4.2.3i Subject: Re: untie the MD4 code from MD5 & replace the MD5 code From: solar@openwall.com (Solar Designer) On Thu, Feb 07, 2008 at 04:21:15PM +0300, Dmitry Stogov wrote: > I assume now the patch is ready to commit. > I'll commit it tomorrow in case of no objections. Yes, it is. No objections from me. Just two minor points: 1. You have not yet fixed the size_t vs. php_uint32 issue in PHP_MD5Final(), leaving it inconsistent with PHP_MD5Update(). This should not affect correctness of the code, but it's just weird. 2. The way you have re-formatted my comments still looks weird to me. Thanks, Alexander