Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:35294 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 52741 invoked by uid 1010); 7 Feb 2008 11:55:30 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 52726 invoked from network); 7 Feb 2008 11:55:30 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Feb 2008 11:55:30 -0000 Authentication-Results: pb1.pair.com smtp.mail=solar@openwall.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=solar@openwall.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain openwall.com designates 195.42.179.200 as permitted sender) X-PHP-List-Original-Sender: solar@openwall.com X-Host-Fingerprint: 195.42.179.200 mother.openwall.net Received: from [195.42.179.200] ([195.42.179.200:4756] helo=mother.openwall.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 09/1B-10179-1B1FAA74 for ; Thu, 07 Feb 2008 06:55:29 -0500 Received: (qmail 5809 invoked from network); 7 Feb 2008 11:55:26 -0000 Received: from localhost (HELO pvt.openwall.com) (127.0.0.1) by localhost with SMTP; 7 Feb 2008 11:55:26 -0000 Received: by pvt.openwall.com (Postfix, from userid 503) id 87D622FD0E; Thu, 7 Feb 2008 14:50:27 +0300 (MSK) Date: Thu, 7 Feb 2008 14:50:27 +0300 To: Dmitry Stogov Cc: Sara Golemon , Stanislav Malyshev , Andi Gutmans , PHP Internals List Message-ID: <20080207115027.GA30811@openwall.com> References: <20071209010552.GA12561@openwall.com> <47A849D0.8050508@zend.com> <20080205235055.GA19309@openwall.com> <47AAD95A.8010109@zend.com> <20080207112109.GA30558@openwall.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080207112109.GA30558@openwall.com> User-Agent: Mutt/1.4.2.3i Subject: Re: [PHP-DEV] faster & public domain MD5 implementation From: solar@openwall.com (Solar Designer) I wrote: > Oh, I am able to reproduce this with my original patch: > > PASS hmac-md5 algorithm [ext/hash/tests/hmac-md5.phpt] > PASS md2 algorithm [ext/hash/tests/md2.phpt] > FAIL md4 algorithm [ext/hash/tests/md4.phpt] > PASS md5 algorithm [ext/hash/tests/md5.phpt] > PASS ripemd128 algorithm [ext/hash/tests/ripemd128.phpt] > > It didn't occur to me to pay attention to the MD4 test after patching > MD5. Really weird. I'll look into it. OK, I think I found it. ext/hash/php_hash_md.h has this: #define PHP_MD4Init PHP_MD5Init which breaks when the two implementations are not that similar anymore. Replacing the MD4 implementation with mine as well would fix this (or hide the bug, depending on your point of view), but for now I think the right fix would be to define a PHP_MD4Init() function explicitly. Alexander