Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:35290
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain sci.fi from 63.208.196.178 cause and error)
Reply-To: jani.taskinen@iki.fi
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: 'PHP Internals' <internals@lists.php.net>
In-Reply-To: <47AADAB2.8090100@lerdorf.com>
References: <47AA5354.7020806@zend.com>  <47AA88A9.4000802@lerdorf.com>
	 <1202376366.26463.3.camel@localhost.localdomain>
	 <47AAD2BD.1030804@lerdorf.com>
	 <1202378529.26463.19.camel@localhost.localdomain>
	 <47AADAB2.8090100@lerdorf.com>
Content-Type: text/plain
Date: Thu, 07 Feb 2008 13:15:20 +0200
Message-ID: <1202382920.26463.36.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] _REQUEST and variable_order
From: jani.taskinen@sci.fi (Jani Taskinen)

A minor clarification: The auto-globals are always there, they're not
always _populated_ though. (JIC someone misunderstood this part :)

On Thu, 2008-02-07 at 02:17 -0800, Rasmus Lerdorf wrote:
[clip]
> directives.  We should focus on the actual problem and make the fewest
> changes possible to solve that.  The actual problem being that by
> default cookie data is in $_REQUEST and that can lead to problems.  So,
> we change that default.  Now, in the few cases out there where someone

So instead of EGPCS the default value of variables_order will be EGPS? 

> really does want cookie data in $_REQUEST we can provide an ini for them
> to enable that.  Since today we don't have the ability to have cookie
> data in $_REQUEST without also having $_COOKIE present, we won't break
> anything by not supporting that edge case.  So I think we can tie the
> two together and perhaps throw a startup error if someone tries to make
> $_REQUEST contain cookie data if variables_order does not include "C"

Sounds reasonable. OTOH, what's keeping us from populating the $_REQUEST
global "on-demand"? So even if C is not in variables_order but is set in
request_variables_order the entries for '$_COOKIE' would be in $_REQUEST
but $_COOKIE itself would be empty still. By quick glance to the code
would suggest that it should be fairly easy to check in
php_auto_globals_create_request() if e.g.
Z_ARRVAL_P(PG(http_globals)[TRACK_VARS_COOKIE] is populated or not and
if not, call sapi_module.treat_data() there.

--Jani

-- 
Patches/Donations: http://pecl.php.net/~jani/