Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:35223
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.146.177 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=IB2n5NxrqKUiHNKyryDharCXj2NU2JMQtIdr7QnZ73kYnRhaoX61XTI8tvkm180tTh0yHu8QVw6nmE1+AkOq/53/rIbP2NrngY2LQwTONKszPzEytw4ggzOkoN2ijtSLmETq8eD6u8oaOktxYd+WrbphSy3XJd+vbTkuboG+0IE=
Message-ID: <28139bc0802052001y434adcccy6c68ed09830fec84@mail.gmail.com>
Date: Wed, 6 Feb 2008 12:01:11 +0800
To: "Tomas Kuliavas" <tokul@users.sourceforge.net>
Cc: internals@lists.php.net
In-Reply-To: <51526.78.61.224.253.1201585363.nsm@avilys.eik.lt>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <200801241426.39756.arnaud.lb@gmail.com>
	 <479A613C.8030604@zend.com>
	 <3hpsp3hmn2de4fard8lkpentg24k70jrhg@4ax.com>
	 <479E80D8.5020206@lerdorf.com>
	 <ci4tp3hro32ukdru6ik4d3t0kqsfounccf@4ax.com>
	 <479EB7ED.8070606@lerdorf.com>
	 <51526.78.61.224.253.1201585363.nsm@avilys.eik.lt>
Subject: Re: [PHP-DEV] [PATCH] Bug #43896 htmlspecialchars returns empty stringoninvalid unicode sequence
From: xuefer@gmail.com (Xuefer)

> iconv() will stop on conversion error and return partial string or empty
> string. It will require even more complex code than 5.2.5
> htmlspecialchars() does. With htmlspecialchars you check for empty string
> before and after the call. With iconv you check for php errors during
> iconv call.
the current impl of iconv() wrap in php is a pain in the @$$, i can
only get truncated string if there's some invalid char, or rely on
glibc "//IGNORE" flag. "string".encode() in python is much better that
u can with 'ignore', 'replace', 'xmlcharrefreplace',
'backslashreplace'  as the 2nd param of encode()
i agree that ignoring the invalid char in "all case" is not good, but
truncating in all case isn't either. there're some case acceptable
like user post -> server accept it, ignoring invalid chars -> and user
have chance to review his text later.

too bad that the conversation implicit like __set/__get that you can't
add one more optional paramter. hope there's some nice way to get this
problem done.