Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:35220
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 66.249.82.232 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=WILbx4g4AmSAePQ+Ru1BEa3oA5CyCPeCz7EweCRgcfN3Id50y+GhyK0VDstcf6iM+xUmbfI6Hai2eCqXNeFiRN2HGc2ZilJduF0/GMFs2pTKHUeTxLfpwZzkUpWBMRelkVBod7Sy6ia8Dy5A7I3s8tnnJR+BmymaRIvFciJCLJE=
Message-ID: <fe05d1540802051730r5e9a30b7t64921f2ee704d5b1@mail.gmail.com>
Date: Wed, 6 Feb 2008 02:30:08 +0100
To: "Rasmus Lerdorf" <rasmus@lerdorf.com>
Cc: "Daniel Brown" <parasane@gmail.com>, 
	"PHP internals" <internals@lists.php.net>
In-Reply-To: <47A909A1.9050201@lerdorf.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <fe05d1540802051223h1306acddw1891ed7f96a13bd0@mail.gmail.com>
	 <ab5568160802051226v478dcf14jba279946f4fe2fc1@mail.gmail.com>
	 <ab5568160802051236h4d803909i44c27f99de617f80@mail.gmail.com>
	 <47A909A1.9050201@lerdorf.com>
Subject: Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision
From: pierre.php@gmail.com ("Pierre Joye")

Hi Rasmus,

On Feb 6, 2008 2:13 AM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote:
> Daniel Brown wrote:
> > On Feb 5, 2008 3:26 PM, Daniel Brown <parasane@gmail.com> wrote:
> >> On Feb 5, 2008 3:23 PM, Pierre Joye <pierre.php@gmail.com> wrote:
> >>> Hi,
> >>>
> >>> It seems that there is voices in favor of keeping the GPC related
> >>> functions in HEAD/php6 but returning always FALSE.
> >>     Personally....
> >>
> >>     XX
> >
> >     VOTE CHANGED
> >
> >     -1
> >
> >     After a quick off-list discussion with Hannes (gotta' love Gmail
> > chat), I realized that I forgot to consider backwards-compatibility.
>
> I think a lot of people miss the point of these particular functions.
> This isn't about whether to keep magic quotes or not, it is whether to
> keep the function that tells you whether magic quote mangling is
> enabled.  There is a lot of code out there that checks to see if this
> feature is on, and deals with that case.  Having this function that
> simply tells the code to take the other path will allow it to work.
> This is not about restoring the magic quotes feature at all.

Exactly, I thought it was clear.

As I can see it was, the votes (not that much ;) in favor of keeping
the functions argue about your example, keep the if
(get_magic_quotes_gpc...) working without changes (if (php6)...).

Cheers,
-- 
Pierre
http://blog.thepimp.net | http://www.libgd.org