Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:35016
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 72.232.140.210 as permitted sender)
Message-ID: <47A05612.4020505@php.net>
Date: Wed, 30 Jan 2008 10:48:50 +0000
User-Agent: Thunderbird 2.0.0.9 (Windows/20071031)
MIME-Version: 1.0
To: php-dev <internals@lists.php.net>
Content-Type: multipart/mixed;
 boundary="------------050001050104060209080405"
Subject: BC break with callbacks in 5.3
From: scottmac@php.net (Scott MacVicar)

--------------050001050104060209080405
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hi all,

Static callbacks behave differently between 5.2 and 5.3, I recently 
noticed this when trying to install PEAR, it printed a warning each time 
call_user_func and call_user_func_array was used.

After some tracking down it seems like the callback option for 
zend_parse_parameters was backported from 6 but the strict check was 
left as is.

<?php
class MyClass { function test($var) { echo "$var\n"; } }
MyClass::Test('regular');
call_user_func(array('MyClass', 'test'), 'callback');
?>

The prints E_STRICT errors in PHP 5.2 but in 5.3 you get a single 
E_STRICT error followed by a warning for call_user_func.

You can resolve this by adding the static keyword to the method 
declaration but regardless it's inconsistent as stands. I think the 
strict flag needs to be removed for 5.3.

Patch is attached to resolve the issue.

Scott

--------------050001050104060209080405
Content-Type: text/plain;
 name="zend_static_callback.diff.txt"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="zend_static_callback.diff.txt"

Index: ZendEngine2/zend_API.c
===================================================================
RCS file: /repository/ZendEngine2/zend_API.c,v
retrieving revision 1.296.2.27.2.34.2.17
diff -u -r1.296.2.27.2.34.2.17 zend_API.c
--- ZendEngine2/zend_API.c	24 Jan 2008 10:49:26 -0000	1.296.2.27.2.34.2.17
+++ ZendEngine2/zend_API.c	30 Jan 2008 10:37:45 -0000
@@ -2568,7 +2568,7 @@
 	zend_function *func;
 	zval **obj;
 
-	if (!zend_is_callable_ex(callable, IS_CALLABLE_STRICT, callable_name, NULL, &ce, &func, &obj TSRMLS_CC)) {
+	if (!zend_is_callable_ex(callable, 0, callable_name, NULL, &ce, &func, &obj TSRMLS_CC)) {
 		return FAILURE;
 	}
 

--------------050001050104060209080405--