Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:34887
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 212.55.154.25 as permitted sender)
Message-ID: <18976126AE41408392C4407AFA8C602D@pc07654>
To: "Dmitry Stogov" <dmitry@zend.com>
Cc: "PHP Internals List" <internals@lists.php.net>
References: <4794F6DA.8010400@zend.com> <247E16805B904E159ACE8E1EC4CF1D5F@pc07654> <479702A4.90607@zend.com>
In-Reply-To: <479702A4.90607@zend.com>
Date: Wed, 23 Jan 2008 17:42:27 -0000
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="iso-8859-1";
	reply-type=response
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Segmented argument_stack
From: nlopess@php.net ("Nuno Lopes")

>> As a side note, I think the following code could be optimized:
>
> Probably it could, but note that the code not just moves the stack 
> pointer, but also destroys arguments there (zval_ptr_dtor).
>
>> + while (zend_vm_stack_top(TSRMLS_C) != stack_frame) {
>> + zval *stack_zval_p = zend_vm_stack_pop(TSRMLS_C);
>> + zval_ptr_dtor(&stack_zval_p);
>>  }
>>
>> I think you can simply discard the last n ptrs on the stack. A 
>> zend_vm_stack_pop(num_elements) would do the trick (or a 
>> zend_vm_stack_pop_until(stack_frame)). That way the function call cleanup 
>> would be a little faster.
>
> May be I misunderstood you. Lets commit unmodified patch and then you'll 
> show me a way to optimize it.

Uhm ok. Maybe I overlooked the issue. Please commit the patch and I'll 
review it again.

Thanks,
Nuno