Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:34822
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.166.178 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=ZWxWFpwa5kZQ2Z6NxKz9DLTDnrnxe3XoGyCi7XjvruqTQjkiau/G9PrxIuS82er6iL7i3QGN0WE8oSKC3JdkwBLl74Q06jDHxYNBEBDMk1Ae9Ki5FoVHCXUR3SqVZl1Vk16gzN22L0Yekj8Pbg7GceWPeojliey922en0nshqFc=
Message-ID: <78c6bd860801171739o3e746302v449afd6f62eaa30b@mail.gmail.com>
Date: Thu, 17 Jan 2008 20:39:23 -0500
To: "Antony Dovgal" <tony@daylessday.org>, internals@lists.php.net
In-Reply-To: <478FC8E4.3050104@daylessday.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <78c6bd860801171233p6f652d3bl54559d51963c1300@mail.gmail.com>
	 <478FC8E4.3050104@daylessday.org>
Subject: Re: [PHP-DEV] Referencing constants in extension code
From: ioplex@gmail.com ("Michael B Allen")

On 1/17/08, Antony Dovgal <tony@daylessday.org> wrote:
> On 17.01.2008 23:33, Michael B Allen wrote:
> > This has worked fine
>
> Are you really sure?

It has worked just fine under load in production with PHP 5, 5.0 and
5.1. It *seems* there's something different about 5.2.

> Does valgrind confirm it?

I have run valgrind (primarily for leak checking) and I don't recall
seeing any complaints about the code or objects in question.

> > PHP_FUNCTION(foo_status)
> > {
> >     zval *r;
> >     char *s = "";
> >     int slen;
> >     struct foo *foo = NULL;
> >
> >     if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "z!|s!",
> >                 &r, &s, &slen) == FAILURE) {
> >         RETURN_FALSE;
> >     }
> >
> >     if (r)
> >         foo = (struct foo *)zend_fetch_resource(&r TSRMLS_CC,
> >                 -1, "foo", NULL, 1, le_foo);
> >
> >     if (ZEND_NUM_ARGS() > 1) {
> >         foo_status(foo) = s; // save the status for possible retrieval later
> >     }
>
> I don't know what "foo_status(foo)" is supposed to mean here,

It's saving s into foo. It's actually an errno style macro that
dereferences a char ** to assign the value to a member of foo.

> but this code was never supposed to work.

Well it did.

> You have to copy the string if you want to store it.

Ok. Doesn't look like I have much choice. I just wanted to understand
the problem better. I'll just copy the strings.

But it does seem odd to me that PHP does not always reference string
constants directly. I mean, why copy if you don't have to?

Mike