Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:34585
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 83.243.58.163 as permitted sender)
To: Faraz Khan <faraz.khan@emergen.biz>
Cc: internals@lists.php.net
In-Reply-To: <20080107205357.19762xnvd5whnbi8@maggie.wswhost.net>
References: <20080107205357.19762xnvd5whnbi8@maggie.wswhost.net>
Content-Type: text/plain
Date: Mon, 07 Jan 2008 18:26:21 +0100
Message-ID: <1199726781.2843.38.camel@johannes.nop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: php ldap wit exop patch and missing ZSTR
From: johannes@php.net (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

Hi Faraz,

On Mon, 2008-01-07 at 20:53 +0500, Faraz Khan wrote:
> Dear all,
> I'm trying to apply the php ldap EXOP patch from :
> 
> <http://www.sys-net.it/~ando/Download/#PHP>
> 
> The patch defines a zstr in ldap.c at line 1731 as obvious below. ZSTR  
> no longer appears to be defined anywhere in php or zend.h - can  
> somebody help me with this? Should i just define it manually?

I don't know that patch but a little help: zstr is a PHP 6 type for
handling unicode and binary strings. So that patch is either missing
some compatibility code or is only for PHP 6. If you want to adopt it
either define a zstr using something like

typedef union _zstr {
	char *s;
	/* void *u;   -- If you get an error due a missing u component 
                         of that union either try using a void for it
                         or change it to take .s as char* .... */
	void *v;
} zstr;

or try to change the "zstr foo"s there to "char *foo" and drop
the .s/.u/.v where that var is being used.

The original declaration of that type can be found here:
http://lxr.php.net/source/ZendEngine2/zend.h#235

Both ways aren't really good, for more I'd have to check the patch,
maybe it's best to ask the author of the patch.

johannes