Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:34268 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 99037 invoked by uid 1010); 28 Dec 2007 11:59:37 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 99021 invoked from network); 28 Dec 2007 11:59:37 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Dec 2007 11:59:37 -0000 Authentication-Results: pb1.pair.com smtp.mail=xuefer@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=xuefer@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.146.176 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: xuefer@gmail.com X-Host-Fingerprint: 209.85.146.176 wa-out-1112.google.com Received: from [209.85.146.176] ([209.85.146.176:8577] helo=wa-out-1112.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id B9/51-22266-825E4774 for ; Fri, 28 Dec 2007 06:59:37 -0500 Received: by wa-out-1112.google.com with SMTP id l24so5976845waf.17 for ; Fri, 28 Dec 2007 03:59:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=8n9Nvz4aGy3STvWMOywx2K75L/+6tsgCjO0f6pPrpns=; b=Z8oTU2VCWd2b8Cdozt62hucA3DWjwg0sTGW7UBv/r9VmlcXNoZbxUeQpqtMDHd0+PPnyEsapYyVNqNaQhB0eq054WGq2x2UYvzOCvSxa38o9u6fA4w7zT/SURmfLGDOMyNpp+vuktk7bDWMfzeB2tLg4DwdT8S+SCNyLNvAJ7Jg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=uu4UMG531yBmsqdM5yUvLzVw0S/qE9H2fc5eQ5/+5mB9fUmcjzZ/mReB4x7XjdDCVSTP50ppfn4US36yraCwAJ6yG1VZXqfvGgRnYot6TEvUH3/zGv5JUEG8sQl+BdM+Rxisxzfdg8JjLIEDCIi/uVo2vmlWEVahWY/N4Wk9QA4= Received: by 10.114.152.17 with SMTP id z17mr8514874wad.128.1198843173828; Fri, 28 Dec 2007 03:59:33 -0800 (PST) Received: by 10.114.36.15 with HTTP; Fri, 28 Dec 2007 03:59:33 -0800 (PST) Message-ID: <28139bc0712280359q1c849367ue8a8fa8853935863@mail.gmail.com> Date: Fri, 28 Dec 2007 19:59:33 +0800 To: "David Wang" Cc: internals@lists.php.net In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: Subject: Re: [PHP-DEV] Patch for macros for tracking refcount and is_ref From: xuefer@gmail.com (Xuefer) why not keep ZVAL_ADDREF ZVAL_DELREF for 3rd party source level compatibility reason and deprecate it? e.g.: pecl/event/event.c: 790 ZVAL_ADDREF(ev->php_cb_arg); On Sep 4, 2007 10:24 PM, David Wang wrote: > > One thing to note is that I removed the existing ZVAL_ADDREF and > ZVAL_DELREF in favor of Z_ADDREF_P and Z_DELREF_P that do the same > thing. The original duo acted on zval pointers contrary to standard > form for macro names.