Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:34265 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 70084 invoked by uid 1010); 28 Dec 2007 09:12:26 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 70069 invoked from network); 28 Dec 2007 09:12:26 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Dec 2007 09:12:26 -0000 Authentication-Results: pb1.pair.com header.from=xuefer@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=xuefer@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.146.176 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: xuefer@gmail.com X-Host-Fingerprint: 209.85.146.176 wa-out-1112.google.com Received: from [209.85.146.176] ([209.85.146.176:22791] helo=wa-out-1112.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id E1/62-54638-9FDB4774 for ; Fri, 28 Dec 2007 04:12:25 -0500 Received: by wa-out-1112.google.com with SMTP id l24so5884871waf.17 for ; Fri, 28 Dec 2007 01:12:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition:x-google-sender-auth; bh=0ueb2CTR6RG8Y3TQmz0qlv85pYOa+B+HToOopnIXNW4=; b=nz9tnnlq27KMFzF92dcGvuHr0b2viOuqmOvy4ssIBmUMxu1+lCJIKNpJ/gVymFzIyKA/MCM+02U8Kr9C1bkNdgkFLb7IxI2QwYbNLFG8XML1l9TNSrf/sslzBFJQnNXUw57XjE91a9bdxxvUuWdSHHD89DyXgBNlic8FjmBnh/4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition:x-google-sender-auth; b=fhQERDcwLy0gLaA4F3EvMYJjqrT+0nRAVMjqvD/ZoDb2McQN0HF3iwwyplR8kGEtdzvGFZ7B5S3URg7FPAB3qgkC5G7hFicUTKVQGNuaDSFWwGSRIIc3mag7Dim3CxS+8RV2dlh08kavf2EIKQn57MY2M4pz0FcguAgAu9ETUd0= Received: by 10.114.15.1 with SMTP id 1mr8717009wao.27.1198833142711; Fri, 28 Dec 2007 01:12:22 -0800 (PST) Received: by 10.114.36.15 with HTTP; Fri, 28 Dec 2007 01:12:22 -0800 (PST) Message-ID: <28139bc0712280112t2f2952e9s2ea3821f452f4074@mail.gmail.com> Date: Fri, 28 Dec 2007 17:12:22 +0800 Sender: xuefer@gmail.com To: "php-dev List" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Google-Sender-Auth: d3703fe9d9dcbfdb Subject: [bug in php5.3 cvs] op2 of OP_DATA which after INIT_NS_FCALL_BY_NAME is uninitialized From: phpxcache@gmail.com (phpxcache) http://bugs.php.net/bug.php?id=43696 Description: ------------ as you can see in zend_compile.c opline->opcode = ZEND_INIT_NS_FCALL_BY_NAME; ZEND_INIT_NS_FCALL_BY_NAME's op1 is initialized, so is op2 ......... opline->opcode = ZEND_OP_DATA; ZEND_OP_DATA's op1 is initialized here but op2 is not it may not cause problem in zend executor but may in opcode optimizers/cachers suggested fix: Index: zend_compile.c =================================================================== RCS file: /repository/ZendEngine2/zend_compile.c,v retrieving revision 1.647.2.27.2.41.2.32 diff -u -r1.647.2.27.2.41.2.32 zend_compile.c --- zend_compile.c 27 Dec 2007 13:52:05 -0000 1.647.2.27.2.41.2.32 +++ zend_compile.c 28 Dec 2007 08:56:41 -0000 @@ -1504,6 +1504,7 @@ Z_TYPE(opline->op1.u.constant) = IS_STRING; Z_STRLEN(opline->op1.u.constant) = Z_STRLEN(function_name->u.constant) - prefix_len; Z_STRVAL(opline->op1.u.constant) = zend_str_tolower_dup(Z_STRVAL(function_name->u.constant) + prefix_len, Z_STRLEN(opline->op1.u.constant)); + SET_UNUSED(opline->op2); opline->extended_value = zend_hash_func(Z_STRVAL(opline->op1.u.constant), Z_STRLEN(opline->op1.u.constant) + 1); } else { opline->opcode = ZEND_INIT_FCALL_BY_NAME;