Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:34240 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 72189 invoked by uid 1010); 24 Dec 2007 20:07:04 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 72158 invoked from network); 24 Dec 2007 20:07:04 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Dec 2007 20:07:04 -0000 Authentication-Results: pb1.pair.com smtp.mail=jon@csh.rit.edu; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=jon@php.net; sender-id=unknown Received-SPF: pass (pb1.pair.com: domain csh.rit.edu designates 129.21.60.19 as permitted sender) X-PHP-List-Original-Sender: jon@csh.rit.edu X-Host-Fingerprint: 129.21.60.19 whitefox.csh.rit.edu Received: from [129.21.60.19] ([129.21.60.19:54128] helo=whitefox.csh.rit.edu) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 6D/72-50075-66110774 for ; Mon, 24 Dec 2007 15:07:02 -0500 Received: from localhost (localhost [127.0.0.1]) by whitefox.csh.rit.edu (Postfix) with ESMTP id 1DD9F11449 for ; Mon, 24 Dec 2007 15:07:00 -0500 (EST) X-Virus-Scanned: amavisd-new at csh.rit.edu Received: from whitefox.csh.rit.edu ([127.0.0.1]) by localhost (whitefox.csh.rit.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LhhI9UYoXN5F for ; Mon, 24 Dec 2007 15:06:44 -0500 (EST) Received: from scorn.csh.rit.edu (scorn.csh.rit.edu [129.21.60.26]) by whitefox.csh.rit.edu (Postfix) with ESMTP id 7F72B1144B for ; Mon, 24 Dec 2007 15:06:44 -0500 (EST) Received: by scorn.csh.rit.edu (Postfix, from userid 37404) id 6275450888; Mon, 24 Dec 2007 15:06:44 -0500 (EST) Date: Mon, 24 Dec 2007 15:06:44 -0500 To: php-dev List Message-ID: <20071224200644.GB51492@csh.rit.edu> Mail-Followup-To: php-dev List References: <98b8086f0712150818n40056cedyf0aae7a5a08a27b7@mail.gmail.com> <476582E6.7020808@zend.com> <200712172130.08216.larry@garfieldtech.com> <4FADC266-873E-4FD2-BEC8-28EA9D833297@procata.com> <476D2854.5070803@gmx.net> <503D0384-1014-4CD1-BCAC-8F0950D5FC68@bitxtender.com> <476E6532.5080402@gmx.net> <20071224040401.GA36003@csh.rit.edu> <476FCCB8.2060604@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <476FCCB8.2060604@gmx.net> Subject: Re: [PHP-DEV] PATCH: Implementing closures in PHP From: jon@php.net (Jon Parise) On Mon, Dec 24, 2007 at 04:14:00PM +0100, Christian Seiler wrote: > > 3. The "is_anonymous" flags could be zend_bool values instead of bare > > integers, although that breaks the precedent started by some > > related flags (such as "is_method"). > > You're right, zend_bool is a better idea. Since PHP 5.3 is going to > break binary compability anyway, would it do any harm changing the > types of the existing flags, too? I don't have a strong opinion one way or another, but other folks might. I think using it would make the API clearer, and there might be memory size benefits when used as a structure member. On the other hand, changing those integers to zend_bool (unsigned char) types could potentially have a runtime performance cost on some platforms (depending on how those values are being marshaled around), but that would have to be measured. -- Jon Parise (jon of php.net) :: The PHP Project (http://www.php.net/)