Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:34238 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 10852 invoked by uid 1010); 24 Dec 2007 14:39:50 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 10837 invoked from network); 24 Dec 2007 14:39:49 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Dec 2007 14:39:49 -0000 Authentication-Results: pb1.pair.com header.from=jon@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=jon@csh.rit.edu; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain csh.rit.edu designates 129.21.60.19 as permitted sender) X-PHP-List-Original-Sender: jon@csh.rit.edu X-Host-Fingerprint: 129.21.60.19 whitefox.csh.rit.edu Received: from [129.21.60.19] ([129.21.60.19:65164] helo=whitefox.csh.rit.edu) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id E8/B0-00317-4B4CF674 for ; Mon, 24 Dec 2007 09:39:49 -0500 Received: from localhost (localhost [127.0.0.1]) by whitefox.csh.rit.edu (Postfix) with ESMTP id 59E461173C for ; Mon, 24 Dec 2007 09:39:46 -0500 (EST) X-Virus-Scanned: amavisd-new at csh.rit.edu Received: from whitefox.csh.rit.edu ([127.0.0.1]) by localhost (whitefox.csh.rit.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q7qOXKvmuFh0 for ; Mon, 24 Dec 2007 09:38:59 -0500 (EST) Received: from scorn.csh.rit.edu (scorn.csh.rit.edu [129.21.60.26]) by whitefox.csh.rit.edu (Postfix) with ESMTP id AE973118E2 for ; Sun, 23 Dec 2007 23:04:01 -0500 (EST) Received: by scorn.csh.rit.edu (Postfix, from userid 37404) id 913B050888; Sun, 23 Dec 2007 23:04:01 -0500 (EST) Date: Sun, 23 Dec 2007 23:04:01 -0500 To: php-dev List Message-ID: <20071224040401.GA36003@csh.rit.edu> Mail-Followup-To: php-dev List References: <98b8086f0712150818n40056cedyf0aae7a5a08a27b7@mail.gmail.com> <476582E6.7020808@zend.com> <200712172130.08216.larry@garfieldtech.com> <4FADC266-873E-4FD2-BEC8-28EA9D833297@procata.com> <476D2854.5070803@gmx.net> <503D0384-1014-4CD1-BCAC-8F0950D5FC68@bitxtender.com> <476E6532.5080402@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <476E6532.5080402@gmx.net> Subject: Re: [PHP-DEV] PATCH: Implementing closures in PHP From: jon@php.net (Jon Parise) On Sun, Dec 23, 2007 at 02:40:02PM +0100, Christian Seiler wrote: > I now updated the patch so that this problem is addressed. You will find > it here: > > http://www.christian-seiler.de/temp/closures-php-5-3-v2.patch A few minor items from a quick read-through of the patch: 1. There appear to be some spurious whitespace insertions in this version of the patch. 2. The terms "lamba" and "anonymous function" are being used interchangeably. If we're going to introduce new terminology, it would be good to pick one name and use it consistently. I don't have a preference for which one is ultimately chosen. The term "lexical" could also be considered a competing term as its used in part of the patch. 3. The "is_anonymous" flags could be zend_bool values instead of bare integers, although that breaks the precedent started by some related flags (such as "is_method"). 4. This part of the zend_vm_def.h diff looks wrong (a stray "f"): -/* +f/* Looks great overall! -- Jon Parise (jon of php.net) :: The PHP Project (http://www.php.net/)