Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:34233 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 46358 invoked by uid 1010); 23 Dec 2007 13:57:50 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 46343 invoked from network); 23 Dec 2007 13:57:49 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Dec 2007 13:57:49 -0000 Authentication-Results: pb1.pair.com smtp.mail=dz@bitxtender.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=dz@bitxtender.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain bitxtender.com from 80.237.132.12 cause and error) X-PHP-List-Original-Sender: dz@bitxtender.com X-Host-Fingerprint: 80.237.132.12 wp005.webpack.hosteurope.de Received: from [80.237.132.12] ([80.237.132.12:43795] helo=wp005.webpack.hosteurope.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 3A/D3-12793-C596E674 for ; Sun, 23 Dec 2007 08:57:49 -0500 Received: from dslb-084-056-044-193.pools.arcor-ip.net ([84.56.44.193] helo=localhost); authenticated by wp005.webpack.hosteurope.de running ExIM using esmtpsa (TLSv1:RC4-SHA:128) id 1J6RKt-0008LI-7H; Sun, 23 Dec 2007 14:57:47 +0100 Cc: php-dev List Message-ID: To: Christian Seiler In-Reply-To: <476E6532.5080402@gmx.net> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v915) Date: Sun, 23 Dec 2007 14:57:39 +0100 References: <98b8086f0712150818n40056cedyf0aae7a5a08a27b7@mail.gmail.com> <476582E6.7020808@zend.com> <200712172130.08216.larry@garfieldtech.com> <4FADC266-873E-4FD2-BEC8-28EA9D833297@procata.com> <476D2854.5070803@gmx.net> <503D0384-1014-4CD1-BCAC-8F0950D5FC68@bitxtender.com> <476E6532.5080402@gmx.net> X-Mailer: Apple Mail (2.915) X-bounce-key: webpack.hosteurope.de;dz@bitxtender.com;1198418270;1de0fa6f; Subject: Re: [PHP-DEV] PATCH: Implementing closures in PHP From: dz@bitxtender.com (=?ISO-8859-1?Q?David_Z=FClke?=) Cool. I hope I'll have the time to give that a shot over the holidays. Great work, nice patch (from what I, with my rubbish knowledge, can tell :D) David Am 23.12.2007 um 14:40 schrieb Christian Seiler: > Hi David! > >> One question about the names you generate for the function table in >> combination with opcode caches. [...] > > I now updated the patch so that this problem is addressed. You will > find > it here: > > http://www.christian-seiler.de/temp/closures-php-5-3-v2.patch > > The compiled functions are now named __compiled_lambda_$hash_$counter, > where $counter is a per-file lambda counter and $hash is a hash made > from the file name (see hash_compiled_filename in zend_compile.c, I > wasn't sure how good Zend's hash function is with duplicates so I > hashed > the file name AND its basename - feel free to change that function if > you have a better idea or know it's safe to only hash the filename > itself because duplicates are too rare). > > Regards, > Christian > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >