Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:34214
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.146.183 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=uuKARUEqarcjYLzOYCA74ENAAJJoZIFrN0AtxlPzqjaZMSfVKEyFoBjQf/GbXL9yOrdJLmX+sxolMbIiYzkAXoQ6RiV9kcxZuxH8yHVD/oc8+EOkvSH9qgnD+kzksjlMLPt407x+1x+4EylRE/L3PONRJEH/awn5ySLoBEzbw7g=
Message-ID: <af54caaf0712220458s4679ca06uebcad4ac899f2f20@mail.gmail.com>
Date: Sat, 22 Dec 2007 12:58:29 +0000
To: "Martin Alterisio" <malterisio777@gmail.com>
Cc: "PHP Developers Mailing List" <internals@lists.php.net>
In-Reply-To: <52dbac0f0712211602y5296932bt72ac90fb577c6af5@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <52dbac0f0712211230v17c0762cs4b9e37db29e2bc34@mail.gmail.com>
	 <af54caaf0712211409m6a0fbd54ob15c405752be144a@mail.gmail.com>
	 <52dbac0f0712211602y5296932bt72ac90fb577c6af5@mail.gmail.com>
Subject: Re: [PHP-DEV] Refactoring code for namespaces appliance
From: paul.biggar@gmail.com ("Paul Biggar")

On Dec 22, 2007 12:02 AM, Martin Alterisio <malterisio777@gmail.com> wrote:
> 2007/12/21, Paul Biggar <paul.biggar@gmail.com>:
>
> > > 4) find all function calls (not method calls) which are not keywords
> (array,
> > > isset, unset, list, etc) and prefix them with ::
> >
> > list, array etc wouldnt be confused with functions. Functions are just
> > methods without target. You'd need a short list of functions such as
> > empty, unset etc to avoid.

> Because isset is actually a keyword.

Right, the phc grammar doesnt differentiate between built-ins and
functions, even though the PHP grammar has rules for each. You just
need a list of the built-ins, such as isset, etc. You'll see when you
start working with phc, but the point I was making was that this isnt
hard.


> > > 6) find static method calls with variables used as class name, and mark
> them
> > > for user handled refactoring
> >
> > I'm not sure why this couldnt be done automatically, but finding
> > static method calls is also easy. You could add comments to mark these
> > fairly easily.
>
> Maybe some workaround can be found to str_replace the namespace separator,
> but I think this wouldn't be optimal and possibly harm code readability and
> maintainability. Consider a factory method:
>
> <?php
>  class Factory {
>   public static function create($what, $arguments) {
>     switch ($what) {
>     case 'bananas':
>       $class = 'Food_Fruit_Banana';
>        break;
>       ...
>      }
>     return $class::create($arguments);
>    }
> }
> ?>
>
> An automated refactoring would be tempted to do:
>
> <?php
>  class Factory {
>    public static function create($what, $arguments) {
>      switch ($what) {
>      case 'bananas':
>        $class = 'Food_Fruit_Banana';
>        break;
>        ...
>      }
>     $temp = str_replace('_', '::', $class);
>      return $temp::create($arguments);
>    }
>  }
>  ?>
>
> Which I think is not the proper way to refactorize this code.
> This would be, IMHO, the right way to refactorize this code:
>
> <?php
>  class Factory {
>    public static function create($what, $arguments) {
>      switch ($what) {
>      case 'bananas':
>        $class = 'Food::Fruit::Banana';
>        break;
>        ...
>      }
>     return $class::create($arguments);
>    }
>  }
>  ?>
>
> Considering the variants and possible uses of this syntax, I'll say it's
> better to leave this job to the coder rather than to an automated job.

True, as I'm sorry to say that we dont have the facilities to
automatically match the definition of variables to where they are
used.
 However, once you have a list of class_names, a global replace on all
strings may be all you need.

Paul

-- 
Paul Biggar
paul.biggar@gmail.com