Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:34196 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 36417 invoked by uid 1010); 21 Dec 2007 09:16:19 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 36402 invoked from network); 21 Dec 2007 09:16:19 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Dec 2007 09:16:19 -0000 Authentication-Results: pb1.pair.com header.from=tony@daylessday.org; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=tony@daylessday.org; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain daylessday.org designates 89.208.40.236 as permitted sender) X-PHP-List-Original-Sender: tony@daylessday.org X-Host-Fingerprint: 89.208.40.236 mail.daylessday.org Linux 2.6 Received: from [89.208.40.236] ([89.208.40.236:46699] helo=daylessday.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A5/70-33062-2648B674 for ; Fri, 21 Dec 2007 04:16:18 -0500 Received: from [192.168.3.87] (unknown [212.42.62.198]) by daylessday.org (Postfix) with ESMTP id 4F18B64010A; Fri, 21 Dec 2007 12:16:15 +0300 (MSK) Message-ID: <476B8458.7030000@daylessday.org> Date: Fri, 21 Dec 2007 12:16:08 +0300 User-Agent: Thunderbird 2.0.0.9 (X11/20071114) MIME-Version: 1.0 To: Martin Alterisio CC: Stanislav Malyshev , Solar Designer , internals@lists.php.net References: <20071209010552.GA12561@openwall.com> <476B0872.3060408@zend.com> <52dbac0f0712201815t3b8d4d7do85980100a26e1609@mail.gmail.com> In-Reply-To: <52dbac0f0712201815t3b8d4d7do85980100a26e1609@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] faster & public domain MD5 implementation From: tony@daylessday.org (Antony Dovgal) On 21.12.2007 05:15, Martin Alterisio wrote: >> http://cvsweb.openwall.com/cgi/cvsweb.cgi/Owl/packages/popa3d/popa3d/md5/ >> >> Tried that one and it is about 30% faster indeed (on md5-only benchmark, >> 32-bit Linux on AMD Opteron. Anybody objects to accepting this? >> >> > Just one, but is a mere formality. I didn't see any copyright notice on the > code nor a licensing document attached. I have not much of the legal > mumbo-jumbo comprehension, so, correct me if I'm wrong, shouldn't external > code that's to be included in the php codebase meet these legal formalities > so it doesn't become a liability? Good point, the license should be explicitly specified. I'm going to test the patch on Linux/64bit today. -- Wbr, Antony Dovgal