Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:34092 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 51978 invoked by uid 1010); 18 Dec 2007 18:42:27 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 51963 invoked from network); 18 Dec 2007 18:42:27 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 18 Dec 2007 18:42:27 -0000 Authentication-Results: pb1.pair.com smtp.mail=rasmus@lerdorf.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=rasmus@lerdorf.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain lerdorf.com from 204.11.219.139 cause and error) X-PHP-List-Original-Sender: rasmus@lerdorf.com X-Host-Fingerprint: 204.11.219.139 mail.lerdorf.com Received: from [204.11.219.139] ([204.11.219.139:47977] helo=mail.lerdorf.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id AB/EB-13895-19418674 for ; Tue, 18 Dec 2007 13:42:26 -0500 Received: from trainburn-lm.corp.yahoo.com (trainburn-lm.corp.yahoo.com [207.126.233.11]) (authenticated bits=0) by mail.lerdorf.com (8.14.2/8.14.2/Debian-2) with ESMTP id lBIIgM72012216 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 18 Dec 2007 10:42:22 -0800 Message-ID: <4768148D.4050709@lerdorf.com> Date: Tue, 18 Dec 2007 10:42:21 -0800 User-Agent: Thunderbird 2.0.0.9 (Macintosh/20071031) MIME-Version: 1.0 To: Ilia Alshanetsky CC: Derick Rethans , Dmitry Stogov , PHP Developers Mailing List References: <698DE66518E7CA45812BD18E807866CEF88FDD@us-ex1.zend.net> <698DE66518E7CA45812BD18E807866CEF89334@us-ex1.zend.net> <47570A20.8070901@zend.com> <698DE66518E7CA45812BD18E807866CEF895BF@us-ex1.zend.net> <4757D355.2060705@zend.com> <4757DA73.5070308@zend.com> <47598BAB.1080808@zend.com> <476157A6.4070400@zend.com> <476646E0.5090608@zend.com> <4767DB03.7080306@zend.com> <52FE13DE-3A5C-4DC5-AFCD-0F63433C5B44@prohost.org> In-Reply-To: <52FE13DE-3A5C-4DC5-AFCD-0F63433C5B44@prohost.org> X-Enigmail-Version: 0.95.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.91.2/5170/Tue Dec 18 07:43:27 2007 on colo.lerdorf.com X-Virus-Status: Clean Subject: Re: [PHP-DEV] Garbage collector patch From: rasmus@lerdorf.com (Rasmus Lerdorf) Making sure it is ifdef'ed nicely would let us leave it in CVS until we get it right and if it causes problems for some people they have a way to build PHP without it. And yes, that means their build won't be binary compatible, which is fine and no different from them trying to revert the patch themselves. -Rasmus Ilia Alshanetsky wrote: > Putting it into CVS into a good idea, but lets create a revert point via > a tag, so we can always easily "undo" the patch if need be. > > > On 18-Dec-07, at 10:05 AM, Derick Rethans wrote: > >> On Tue, 18 Dec 2007, Dmitry Stogov wrote: >> >>> Derick Rethans wrote: >>>> On Mon, 17 Dec 2007, Dmitry Stogov wrote: >>>> >>>>> Didn't I send it to you? >>>> >>>> Maybe, maybe not :) I couldn't find it atleast. >>>> I just tried to apply this to PHP 5.3, but it gives lots of failed >>>> chucks... >>>> Are you sure this is the one against 5.3? >>>> >>> Probably I've changed ZE after the patch was done :( >>> I'll rebuild it, but not today. >> >> Maybe we just should put it in cvs then? Then we won't have this issue >> and other people can test it more easily as well. >> >> regards, >> Derick >> >> -- >> Derick Rethans >> http://derickrethans.nl | http://ezcomponents.org | http://xdebug.org >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> > > Ilia Alshanetsky >