Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:34031
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 64.97.136.145 cause and error)
Message-ID: <07d801c83e35$54df0570$e6dfc350@foxbox>
Reply-To: "Steph Fox" <steph@zend.com>
To: "internals" <internals@lists.php.net>
Date: Fri, 14 Dec 2007 09:40:13 -0000
Organization: Zend Technologies
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="----=_NextPart_000_07D5_01C83E35.53C90190"
Subject: Extension dependencies in win32 build
From: steph@zend.com ("Steph Fox")

------=_NextPart_000_07D5_01C83E35.53C90190
Content-Type: text/plain;
	format=flowed;
	charset="utf-8";
	reply-type=original
Content-Transfer-Encoding: 7bit

Hi all,

Having spent a few hours tussling with the load-order bogey, I found what I 
think is a bit of a gap in the win32 build process.

There are no configure warnings at all when there's a missing extension 
dependency... only a bailout if you try to build a dependency as shared for 
a static extension. The need to bail out would depend on how full-on the 
'dependency' in question is, and I'd guess that can be variable.

Trivial patch attached, would've saved me a lot of brain-ache if it had been 
in CVS yesterday but see what you think.

- Steph 

------=_NextPart_000_07D5_01C83E35.53C90190
Content-Type: text/plain;
	format=flowed;
	name="win32_dependencies.txt";
	reply-type=original
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
	filename="win32_dependencies.txt"

Index: win32/build/confutils.js=0A=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A=
RCS file: /repository/php-src/win32/build/confutils.js,v=0A=
retrieving revision 1.60.2.1.2.8.2.1=0A=
diff -u -r1.60.2.1.2.8.2.1 confutils.js=0A=
--- win32/build/confutils.js	14 Nov 2007 19:38:57 -0000	1.60.2.1.2.8.2.1=0A=
+++ win32/build/confutils.js	14 Dec 2007 09:22:54 -0000=0A=
@@ -1009,7 +1009,15 @@=0A=
 		ADD_FLAG("LDFLAGS_" + EXT, "/libpath:$(BUILD_DIR)");=0A=
 		ADD_FLAG("LIBS_" + EXT, "php_" + dependson + ".lib");=0A=
 		ADD_FLAG("DEPS_" + EXT, "$(BUILD_DIR)\\php_" + dependson + ".lib");=0A=
-	}=0A=
+	} else {=0A=
+		if (dep_present =3D=3D "no") {=0A=
+			if (ext_shared) {=0A=
+				WARNING(extname + " has a missing dependency: " + dependson);=0A=
+			} else {=0A=
+				ERROR("Cannot build " + extname + "; " + dependson + " not =
enabled");=0A=
+			}=0A=
+		}=0A=
+	} // dependency is statically built-in to PHP=0A=
 }=0A=
 =0A=
 function EXTENSION(extname, file_list, shared, cflags, dllname, obj_dir)=0A=

------=_NextPart_000_07D5_01C83E35.53C90190--