Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:33907
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 64.97.136.188 cause and error)
Message-ID: <023301c83b62$36614fc0$e6dfc350@foxbox>
Reply-To: "Steph Fox" <steph@zend.com>
To: "Stanislav Malyshev" <stas@zend.com>
Cc: <internals@lists.php.net>
References: <46.93.08781.F374D474@pb1.pair.com> <474d5320.0d135e0a.43d0.ffffd2b3@mx.google.com> <474D6813.9090606@eenterphace.org> <474DB7F8.5010907@zend.com> <016b01c83ae3$c3acfb60$e6dfc350@foxbox> <475CCA82.2010204@zend.com> <018b01c83aec$7413b2c0$e6dfc350@foxbox> <475CD134.9020005@zend.com> <00c001c83b4c$12cb0f30$e6dfc350@foxbox> <475D7F3B.30504@zend.com> <020c01c83b5d$93c04db0$e6dfc350@foxbox> <475D8D76.3070909@zend.com>
Date: Mon, 10 Dec 2007 19:23:07 -0000
Organization: Zend Technologies
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="iso-8859-1";
	reply-type=response
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] question regarding type hinting parameters of php functions (array_slice)
From: steph@zend.com ("Steph Fox")

>>     if (ZEND_NUM_ARGS() >= 3 && Z_TYPE_P(length_param) != IS_NULL) {
>> +        convert_to_long(length_param);
>
> Isn't convert_to_long non-separating one? I think the variable supposed to 
> be separated before conversion, so convert_to_long_ex (and zval **) would 
> be in place.

Hm you're probably right...

  if (ZEND_NUM_ARGS() >= 3 && Z_TYPE_P(length_param) != IS_NULL) {
+  convert_to_long_ex(&length_param);
   length = Z_LVAL_P(length_param);
  } else {
   length = num_in;

- because it's a zval * these days. convert_to_long() didn't break it when I 
checked, though I probably have the length assignment wrong in the one I 
posted, on reflection. (Too many patches floating around here at present, 
sorry.)

>> +    if (length == IS_NULL) {
>
> Did you really mean IS_NULL here?

It builds without complaint and works as expected - what am I missing?

- Steph

> -- 
> Stanislav Malyshev, Zend Software Architect
> stas@zend.com   http://www.zend.com/
> (408)253-8829   MSN: stas@zend.com