Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:33892
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 64.97.136.185 cause and error)
Message-ID: <018b01c83aec$7413b2c0$e6dfc350@foxbox>
Reply-To: "Steph Fox" <steph@zend.com>
To: "Stanislav Malyshev" <stas@zend.com>
Cc: <internals@lists.php.net>
References: <46.93.08781.F374D474@pb1.pair.com> <474d5320.0d135e0a.43d0.ffffd2b3@mx.google.com> <474D6813.9090606@eenterphace.org> <474DB7F8.5010907@zend.com> <016b01c83ae3$c3acfb60$e6dfc350@foxbox> <475CCA82.2010204@zend.com>
Date: Mon, 10 Dec 2007 05:20:58 -0000
Organization: Zend Technologies
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="iso-8859-1";
	reply-type=response
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] question regarding type hinting parameters of php functions (array_slice)
From: steph@zend.com ("Steph Fox")

>>> I think in fact it should just parse it as long and not as zval - what 
>>> would be any reason to parse it as zval and then convert to long anyway?
>>
>> The problem is that this function's always been wrong, so it doesn't 
>> really care what you throw at it - it just does a silent conversion to 
>> long if you get it wrong. If you turn the parameter into a long now,
>
> Right, that's what "l" parameter spec is doing, doesn't it? Why convert it 
> manually?

Because it doesn't know the difference between NULL and 0 if it's a long.

>> There's also the issue of what to do about inappropriate vs appropriate 
>> input types, since we can't rely on zend_parse_parameters() to 
>> psychically know that this particular zval is really a loose long kind of 
>> thing... so I tried:
>
> What's "loose long"?

One that doesn't break every script that didn't strictly stay with int over 
the last 8 years or so.

>> So - not as straightforward as it looks, whatever way you look at it. 
>> Maybe we should just revert to the old, messy but mostly working code for 
>> array_slice()?
>
> I still don't understand what prevents one from using new parameter 
> parsing API and why manual conversions doing the same are needed.

See above. Unless you know a way to make IS_NULL work the same way with a 
long as it does with a zval anyways.

- Steph