Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:33486 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 14614 invoked by uid 1010); 28 Nov 2007 18:48:33 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 14599 invoked from network); 28 Nov 2007 18:48:33 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Nov 2007 18:48:33 -0000 Authentication-Results: pb1.pair.com header.from=stas@zend.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=stas@zend.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender) X-PHP-List-Original-Sender: stas@zend.com X-Host-Fingerprint: 212.25.124.162 mail.zend.com Windows 2000 SP4, XP SP1 Received: from [212.25.124.162] ([212.25.124.162:47995] helo=mx1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A0/F3-19722-FF7BD474 for ; Wed, 28 Nov 2007 13:48:33 -0500 Received: from us-ex1.zend.com ([192.168.16.5]) by mx1.zend.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 28 Nov 2007 20:48:28 +0200 Received: from [192.168.16.91] ([192.168.16.91]) by us-ex1.zend.com with Microsoft SMTPSVC(6.0.3790.1830); Wed, 28 Nov 2007 10:48:25 -0800 Message-ID: <474DB7F8.5010907@zend.com> Date: Wed, 28 Nov 2007 10:48:24 -0800 Organization: Zend Technologies User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: Moritz Bechler CC: Marco Kaiser , 'Dirk Thomas / 4wd media' , internals@lists.php.net References: <46.93.08781.F374D474@pb1.pair.com> <474d5320.0d135e0a.43d0.ffffd2b3@mx.google.com> <474D6813.9090606@eenterphace.org> In-Reply-To: <474D6813.9090606@eenterphace.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 28 Nov 2007 18:48:25.0163 (UTC) FILETIME=[41D741B0:01C831EF] Subject: Re: [PHP-DEV] question regarding type hinting parameters of php functions (array_slice) From: stas@zend.com (Stanislav Malyshev) > the code is > > if (ZEND_NUM_ARGS() >= 3 && Z_TYPE_P(length_param) != IS_NULL) { > length = Z_LVAL_P(length_param); > } else { > length = num_in; > } > > and afaik should be I think in fact it should just parse it as long and not as zval - what would be any reason to parse it as zval and then convert to long anyway? -- Stanislav Malyshev, Zend Software Architect stas@zend.com http://www.zend.com/ (408)253-8829 MSN: stas@zend.com