Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:33459 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 63666 invoked by uid 1010); 27 Nov 2007 15:51:15 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 63651 invoked from network); 27 Nov 2007 15:51:15 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Nov 2007 15:51:15 -0000 Authentication-Results: pb1.pair.com smtp.mail=andy@petdance.com; spf=permerror; sender-id=softfail Authentication-Results: pb1.pair.com header.from=andy@petdance.com; sender-id=softfail Received-SPF: error (pb1.pair.com: domain petdance.com from 69.17.117.8 cause and error) X-PHP-List-Original-Sender: andy@petdance.com X-Host-Fingerprint: 69.17.117.8 mail6.sea5.speakeasy.net Linux 2.5 (sometimes 2.4) (4) Received: from [69.17.117.8] ([69.17.117.8:48090] helo=mail6.sea5.speakeasy.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 22/F8-09419-2FC3C474 for ; Tue, 27 Nov 2007 10:51:15 -0500 Received: (qmail 30720 invoked from network); 27 Nov 2007 15:51:11 -0000 Received: from rocket.petdance.com (HELO uniqua.petdance.com) ([64.81.227.163]) (envelope-sender ) by mail6.sea5.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 27 Nov 2007 15:51:11 -0000 Received: from alester.flr.follett.com (host3130.follett.com [12.47.12.130]) by uniqua.petdance.com (Postfix) with ESMTP id 930136ED8002; Tue, 27 Nov 2007 09:51:10 -0600 (CST) Cc: "Alexey Zakhlestin" , "Stanislav Malyshev" , internals@lists.php.net Message-ID: To: Ilia Alshanetsky In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v915) Date: Tue, 27 Nov 2007 09:50:49 -0600 References: <20071127074757.GA25945@petdance.com> <474BDAF8.6020308@zend.com> <9AFAC4FC-6B0A-4917-8C5F-9DEA4827B3AB@petdance.com> X-Mailer: Apple Mail (2.915) Subject: Re: [PHP-DEV] [PATCH] Clean up struct initalizations From: andy@petdance.com (Andy Lester) On Nov 27, 2007, at 9:49 AM, Ilia Alshanetsky wrote: > GCC will spue a slew of warnings that can be safely ignored and in > some cases are bogus. The pedantic changes only make the code harder > to read and yield very little if any benefits in return. For larger, > more complex structs like zvals it'll only create a meaningless > mess. There is absolutely no reason that any half decent compiler > will not be able to understand {0} for any declared struct. My goal here is to improve long-term maintainability of the code, by letting compilers and tools like splint do their automated magic where possible. If this is not useful to the PHP core team, then that's fine, I'll walk away. Let me know either way. xoa -- Andy Lester => andy@petdance.com => www.petdance.com => AIM:petdance