Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:33456 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 24985 invoked by uid 1010); 27 Nov 2007 14:34:50 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 24970 invoked from network); 27 Nov 2007 14:34:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Nov 2007 14:34:50 -0000 Authentication-Results: pb1.pair.com header.from=indeyets@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=indeyets@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.170.184 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: indeyets@gmail.com X-Host-Fingerprint: 64.233.170.184 rn-out-0910.google.com Linux 2.4/2.6 Received: from [64.233.170.184] ([64.233.170.184:30463] helo=rn-out-0102.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 1B/82-09419-90B2C474 for ; Tue, 27 Nov 2007 09:34:50 -0500 Received: by rn-out-0102.google.com with SMTP id s28so611180rnb for ; Tue, 27 Nov 2007 06:34:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=lrhbXgU8/9HUNOYwdGrHgdDWQGYf+cNPZyMaHZq8cW0=; b=bGWQfm3AYDFIP9YaZ1gl91e9RU7EV68aWmSSPPbqZftJrOUuQAV+dx+W2tmF4a5D3njiIm2fI3jd/f2gBvwH59JazjH5BErjrjXiaGQURWxVpqhgJlomfp3YvsbUFBsbjs1GigPxMRhhZgHaGUsaHBzgGc0aUI3fgfGPG+tF45Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=OjaUdUO47I7o8doyT4qy+ftUmCW2Vm1GsUcV2VrvFYi88DkN73aWCLZCPmIgmCVKX9rW+bRn/inii59F4o1lmo59yl/X3hS+K38TECd1ET+3v165j9cTGkX2VePElMm/JRtkc+1Z5lHVp6iN7MTjKvcy7dNxB64pEyU3O9hT8yY= Received: by 10.150.96.10 with SMTP id t10mr853976ybb.1196174086525; Tue, 27 Nov 2007 06:34:46 -0800 (PST) Received: by 10.150.57.12 with HTTP; Tue, 27 Nov 2007 06:34:46 -0800 (PST) Message-ID: Date: Tue, 27 Nov 2007 17:34:46 +0300 To: "Ilia Alshanetsky" Cc: "Andy Lester" , "Stanislav Malyshev" , internals@lists.php.net In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20071127074757.GA25945@petdance.com> <474BDAF8.6020308@zend.com> Subject: Re: [PHP-DEV] [PATCH] Clean up struct initalizations From: indeyets@gmail.com ("Alexey Zakhlestin") On 11/27/07, Ilia Alshanetsky wrote: > IMHO {0} is sufficiently clear for human consumption. {NULL, 0, 0} brings real structure dimensions to the context, which is good (less need to check "headers"). > On 27-Nov-07, at 8:49 AM, Andy Lester wrote: > > > > > On Nov 27, 2007, at 2:53 AM, Stanislav Malyshev wrote: > > > >>> I've been working on making PHP build under more stringent error > >>> checking, specifically -Wextra under GCC. This patch cleans up > >>> dozens > >>> of struct initializations that are valid C, but could hide future > >>> problems. > >> > >> Doesn't C standard mandate filling up uninitialized fields with 0? > > > > > > Yes. My patch is for human benefit, not the compiler's. > > > > -- > > Andy Lester => andy@petdance.com => www.petdance.com => AIM:petdance > > > > -- > > PHP Internals - PHP Runtime Development Mailing List > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > Ilia Alshanetsky > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Alexey Zakhlestin http://blog.milkfarmsoft.com/