Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:33454 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 5820 invoked by uid 1010); 27 Nov 2007 13:49:49 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 5805 invoked from network); 27 Nov 2007 13:49:49 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Nov 2007 13:49:49 -0000 Authentication-Results: pb1.pair.com smtp.mail=andy@petdance.com; spf=permerror; sender-id=softfail Authentication-Results: pb1.pair.com header.from=andy@petdance.com; sender-id=softfail Received-SPF: error (pb1.pair.com: domain petdance.com from 69.17.117.3 cause and error) X-PHP-List-Original-Sender: andy@petdance.com X-Host-Fingerprint: 69.17.117.3 mail1.sea5.speakeasy.net Linux 2.5 (sometimes 2.4) (4) Received: from [69.17.117.3] ([69.17.117.3:37880] helo=mail1.sea5.speakeasy.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 2E/CB-24478-C702C474 for ; Tue, 27 Nov 2007 08:49:49 -0500 Received: (qmail 27138 invoked from network); 27 Nov 2007 13:49:45 -0000 Received: from rocket.petdance.com (HELO uniqua.petdance.com) ([64.81.227.163]) (envelope-sender ) by mail1.sea5.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 27 Nov 2007 13:49:44 -0000 Received: from mel.petdance.com (mel.petdance.com [192.168.2.6]) by uniqua.petdance.com (Postfix) with ESMTP id 39B595CD008E; Tue, 27 Nov 2007 07:49:44 -0600 (CST) Cc: internals@lists.php.net Message-ID: To: Stanislav Malyshev In-Reply-To: <474BDAF8.6020308@zend.com> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v915) Date: Tue, 27 Nov 2007 07:49:42 -0600 References: <20071127074757.GA25945@petdance.com> <474BDAF8.6020308@zend.com> X-Mailer: Apple Mail (2.915) Subject: Re: [PHP-DEV] [PATCH] Clean up struct initalizations From: andy@petdance.com (Andy Lester) On Nov 27, 2007, at 2:53 AM, Stanislav Malyshev wrote: >> I've been working on making PHP build under more stringent error >> checking, specifically -Wextra under GCC. This patch cleans up >> dozens >> of struct initializations that are valid C, but could hide future >> problems. > > Doesn't C standard mandate filling up uninitialized fields with 0? Yes. My patch is for human benefit, not the compiler's. -- Andy Lester => andy@petdance.com => www.petdance.com => AIM:petdance