Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:33388 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 34673 invoked by uid 1010); 23 Nov 2007 10:51:15 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 34658 invoked from network); 23 Nov 2007 10:51:15 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Nov 2007 10:51:15 -0000 Authentication-Results: pb1.pair.com header.from=helly@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=helly@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.94.56 as permitted sender) X-PHP-List-Original-Sender: helly@php.net X-Host-Fingerprint: 85.214.94.56 aixcept.net Linux 2.6 Received: from [85.214.94.56] ([85.214.94.56:35365] helo=h1149922.serverkompetenz.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 34/05-02878-3A0B6474 for ; Fri, 23 Nov 2007 05:51:15 -0500 Received: from dhcp-172-28-204-176.zrh.corp.google.com (unknown [193.142.125.1]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by h1149922.serverkompetenz.net (Postfix) with ESMTP id 618231B3674; Fri, 23 Nov 2007 11:51:12 +0100 (CET) Date: Fri, 23 Nov 2007 11:51:11 +0100 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <15010689782.20071123115111@marcus-boerger.de> To: Andy Lester CC: internals@lists.php.net In-Reply-To: References: <474670EF.3030903@daylessday.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Cleanup and maintenance of internal C code From: helly@php.net (Marcus Boerger) Hello Andy, changing to const where possible is a damn good thing and on our list for long. We also wanted to get rid of TSRMLS_FETCH() wherever possible. For instance we should do this change: typedef int (*apply_func_args_t)(void *pDest, int num_args, va_list args, zend_hash_key *hash_key); ZEND_API void zend_hash_apply_with_arguments(HashTable *ht, apply_func_args_t apply_func, int, ...); to: typedef int (*apply_func_args_t)(void *pDest TSRMLS_DC, int num_args, va_list args, zend_hash_key *hash_key); ZEND_API void zend_hash_apply_with_arguments(HashTable *ht TSRMLS_DC, apply_func_args_t apply_func, int, ...); and there are more of those. Since I think your offer is very good, I suggest you provide a few patches for HEAD and 5.3 and if that turns out to be good, we'll give you cvs access. Thats's how we all started. marcus Friday, November 23, 2007, 7:25:55 AM, you wrote: > On Nov 23, 2007, at 12:19 AM, Antony Dovgal wrote: >> Take a look at 5_3 and HEAD, we've done this already a couple of >> months ago: >> http://news.php.net/php.cvs/46317 > So I see. That's a good sign. There's still plenty of other places > to hit, too. Are we interested in jacking up compiler warning levels, > too? I was surprised to see that GCC doesn't default to running with - > Wall in the Makefile. > Just read through README.SUBMITTING-PATCH, so will be mailing stuff > in, as with the bug in browscap.c I just stumbled across. > xoa > -- > Andy Lester => andy@petdance.com => www.petdance.com => AIM:petdance Best regards, Marcus