Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:3322 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 8664 invoked from network); 9 Jul 2003 03:38:40 -0000 Received: from unknown (HELO mail.kromann.info) (64.186.239.125) by pb1.pair.com with SMTP; 9 Jul 2003 03:38:40 -0000 Received: from Swwwing2000 (unknown [64.186.239.115]) by mail.kromann.info (Postfix) with SMTP id 7F11E2AF77; Tue, 8 Jul 2003 20:38:39 -0700 (PDT) To: iliaa@php.net Cc: internals@lists.php.net X-Mailer: Swwwing 2000 Message-ID: <10577219380120000@9866357972520000.9866341568840000> MIME-Version: 1.0 Reply-To: "Frank M. Kromann" Date: Tue, 08 Jul 2003 20:38:59 -0700 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Subject: ext/ming/ming.c From: frank@kromann.info ("Frank M. Kromann") Hi iliaa, You made a change to this file rev 1.48 with the comment Fixed a crash when text is added before a font is specified This fix makes the module compile with warnings and crash on Win32 (when compiled with ming-cvs). This fix is not needed at the ming functions do check for a valid font. The fix is also incorrect as getText() returns a SWFtext structure and not a zval* I think it is safe to revert this patch - Frank