Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:33139
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.94.56 as permitted sender)
Date: Wed, 14 Nov 2007 16:25:27 +0100
Reply-To: Marcus Boerger <helly@php.net>
Message-ID: <1007367897.20071114162527@marcus-boerger.de>
To: Andrew Minerd <andrew.minerd@sellingsource.com>
CC: internals@lists.php.net
In-Reply-To: <20071106125119.6d073e9f@h4x0r.tss>
References: <20071106125119.6d073e9f@h4x0r.tss>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [Patch] Allow __sleep to return NULL
From: helly@php.net (Marcus Boerger)

Hello Andrew,

  the patches look fine. Can you include the test change in both HEAD and
5.3 version of an updated patch (it got outdated meanwhile).

marcus

Tuesday, November 6, 2007, 9:51:19 PM, you wrote:

> I've attached a patch (both for HEAD and the PHP_5_3 branch) that allows the magic __sleep()
> method to return NULL to continue the normal serialization process (all members are
> serialized). This allows the __sleep() method to do meaningful cleanup without having to
> resort to Reflection overhead. The patch retains the original behavior (E_NOTICE) if anything
> other than an array or NULL is returned from the function.

> I check the results of a "make test" on the PHP_5_3 branch with and without the patch. I
> skipped the results from HEAD because there were so many unrelated failures it was pointless.
> The one additional failure in 5.3 with the patch is actually a reverse unit test. I've
> included a patch (separately, because it's the same for HEAD and PHP_5_3) to correct the
> expected result from this test.

> Thanks,

> Andrew



Best regards,
 Marcus