Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:32819
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain omniti.com designates 66.225.209.50 as permitted sender)
DomainKey-Status: good
DomainKey-Signature: q=dns; a=rsa-sha1; c=nofws;
	s=test; d=omniti.com;
	h=Authentication-Results:Received:In-Reply-To:References:Mime-Version:Content-Type:Message-Id:Cc:Content-Transfer-Encoding:From:Subject:Date:To:X-Mailer;
	b=b5hgMDqbO0B+5WEbLKzu56YK+C1H4U3JfqF2Th6orUOIzC0u1hLEkDKc848BOZDB
	iIozjMvBpM5hG3DpwF8VJncpa/vQp7lQnuwKBX444OwDXMT7bqbzpiB/I7umzJ/r
In-Reply-To: <4715382F.9040906@zend.com>
References: <64ED731E-CA44-498E-9AF9-C9B00037B863@omniti.com> <4713A637.7070100@zend.com> <0FF7924D-52E6-4B22-B494-6E252477B389@omniti.com> <4715382F.9040906@zend.com>
Mime-Version: 1.0 (Apple Message framework v752.3)
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-ID: <5CAF7099-5A25-4595-98F3-5F27DEE84EEC@omniti.com>
Cc: internals@lists.php.net
Content-Transfer-Encoding: 7bit
Date: Tue, 16 Oct 2007 18:20:25 -0400
To: Stanislav Malyshev <stas@zend.com>
Subject: Re: [PHP-DEV] Large file support for PHP
From: wez@omniti.com (Wez Furlong)

You might have a point there; I'd assumed that CFLAGS made it through  
to php-config, but it doesn't look like they do.
It should be a simple matter to define them in php_config.h instead.

--Wez.

On Oct 16, 2007, at 6:16 PM, Stanislav Malyshev wrote:

>> Yes, the patch does that; it turns on LFS in the headers, which  
>> promotes the off_t and size_t types that are used by streams to  
>> the 64-bit versions.  This is the one liner in configure.in.
>> The other larger part of the patch is to make PHP functions  
>> capable of returning and accepting numbers that are too big to fit  
>> into a long.
>
> I think it's better to do it in .h file and not CFLAGS (or both?)  
> so that if somebody includes PHP headers they would always get the  
> same result. This would prevent one from building incompatible module.
>
> Is it guaranteed that once you have this define you would always  
> get the same result on all builds (regardless of libc difference,  
> etc.)?
> -- 
> Stanislav Malyshev, Zend Software Architect
> stas@zend.com   http://www.zend.com/
> (408)253-8829   MSN: stas@zend.com