Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:32804
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain seanius.net from 66.93.22.232 cause and error)
To: internals@lists.php.net
Date: Tue, 16 Oct 2007 08:44:02 +0200
User-Agent: KMail/1.9.7
Cc: Stanislav Malyshev <stas@zend.com>,
 Wez Furlong <wez@omniti.com>
References: <64ED731E-CA44-498E-9AF9-C9B00037B863@omniti.com> <4713A637.7070100@zend.com>
In-Reply-To: <4713A637.7070100@zend.com>
MIME-Version: 1.0
Content-Type: multipart/signed;
  boundary="nextPart1384208.jYWkdZl7p6";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit
Message-ID: <200710160844.03049.seanius@seanius.net>
Subject: Re: [PHP-DEV] Large file support for PHP
From: seanius@seanius.net (sean finney)

--nextPart1384208.jYWkdZl7p6
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

hi,

On Monday 15 October 2007 07:41:11 pm Stanislav Malyshev wrote:
> I didn't dive yet too deep into the patch, but shouldn't it be fixed on
> stream level and not function level? I.e. there are a lot of functions
> using streams (including files) - would they support bigger files too?

i would suggest that anywhere where one is doing something with a size or=20
offset and not using the posix size_t/off_t types should get such changes. =
=20
and like i said, i don't see the motivation behind this extra step of=20
returning the size in double form if it's bigger than LONG_MAX.

> I also think that while using size_t is good, changing binary structures
> might be rather dangerous, unless we can ensure all PHPs built on the
> certain platform would use the same setting.

i don't think switching from long/int -> size_t is a problem in the scope o=
f=20
function internal variables.  the only place where you need to worry about=
=20
this is in headers/structs/function declarations that are exported to the=20
API/ABI.


	sean

--nextPart1384208.jYWkdZl7p6
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBHFF2zynjLPm522B0RAl0OAJwIK/7vaILi1e3a1Qz4gzHnmLLV4gCfdogh
eQrRfghLIPtkREuuUyYIQ3E=
=O9tv
-----END PGP SIGNATURE-----

--nextPart1384208.jYWkdZl7p6--