Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:32791
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain mkj-computing.de from 213.239.209.74 cause and error)
Date: Mon, 15 Oct 2007 21:18:23 +0200
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-ID: <7C37FF3A0196094F95430BA95952032211B7D2@s1.mkj.lan>
In-Reply-To: <002f01c80f5b$d645d340$15b2a8c0@unterwegs>
Content-class: urn:content-classes:message
Thread-Topic: [PHP-DEV] Method overloading by method signature
thread-index: AcgPXN0oIZFJDBc7TSS7N1SqsfB+PgAAGkzg
References: <7C37FF3A0196094F95430BA95952032211B7C5@s1.mkj.lan> <cd5680a20710131322k110ee1e4q9194d8390df398f3@mail.gmail.com> <7C37FF3A0196094F95430BA95952032211B7C7@s1.mkj.lan> <72129346.20071014092922@marcus-boerger.de> <7C37FF3A0196094F95430BA95952032211B7CC@s1.mkj.lan> <19939840.20071014231353@marcus-boerger.de> <002f01c80f5b$d645d340$15b2a8c0@unterwegs>
To: "Timm Friebe" <thekid@thekid.de>
Cc: <internals@lists.php.net>
Subject: AW: [PHP-DEV] Method overloading by method signature
From: hans.moog@mkj-computing.de ("Hans Moog")

When it would be:

=3D=3D
  function xpath(DomDocument $arg) {
    return new DomXPath($arg);
  }

  function xpath(XmlTree $arg) {
    return new DomXPath($this->loadXML($arg->getSource())));
  }

  function xpath(string $arg) {
    return new DomXPath($this->loadXML($arg));
  }
=3D=3D
 =20
(since when method overloding by sigantures wer put into php, scalar =
types should be possible, too, shouldn't they?)

I would prefer the second one because I understand the behaviour much =
faster than analyzing the if switch (and this if switch is really simple =
to understand because there is only one command in every block). The =
second reason for me to select the second version is, that I am able to =
write better documentation for each behaviour (although, in this =
situation there isn't that much to be commented).
=20
-----Urspr=FCngliche Nachricht-----
Von: Timm Friebe [mailto:thekid@thekid.de]=20
Gesendet: Montag, 15. Oktober 2007 20:47
An: internals@lists.php.net
Betreff: Re: [PHP-DEV] Method overloading by method signature

Hi,

[...]
> Later we added type hints to help code readability.

Let me jump at this:

=3D=3D
  function xpath($arg) {
    if ($arg instanceof DomDocument) {
      return new DomXPath($arg);
    } else if ($arg instanceof XmlTree) {
      return new DomXPath($this->loadXML($arg->getSource()));
    } else if (is_string($arg)) {
      return new DomXPath($this->loadXML($arg));
    } else {
      throw new IllegalArgumentException('Unsupported argument type');
    }
  }

=3D=3D vs. =3D=3D

  function xpath(DomDocument $arg) {
    return new DomXPath($arg);
  }

  function xpath(XmlTree $arg) {
    return new DomXPath($this->loadXML($arg->getSource())));
  }

  function xpath($arg) {          // Untyped =3D default
    if (!is_string($arg)) {
      throw new IllegalArgumentException('Unsupported argument type');
    }
    return new DomXPath($this->loadXML($arg));
  }

=3D=3D

If we consider the readability argument only: Which one of the above =
more=20
readable? You decide:)

- Timm=20

--=20
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php