Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:32786 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 92783 invoked by uid 1010); 15 Oct 2007 18:31:50 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 92768 invoked from network); 15 Oct 2007 18:31:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 Oct 2007 18:31:50 -0000 Authentication-Results: pb1.pair.com header.from=wez@omniti.com; sender-id=pass; domainkeys=good Authentication-Results: pb1.pair.com smtp.mail=wez@omniti.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain omniti.com designates 66.225.209.50 as permitted sender) DomainKey-Status: good X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: wez@omniti.com X-Host-Fingerprint: 66.225.209.50 mail.omniti.com Linux 2.5 (sometimes 2.4) (4) Received: from [66.225.209.50] ([66.225.209.50:32891] helo=mail.omniti.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 4F/C2-39149-512B3174 for ; Mon, 15 Oct 2007 14:31:49 -0400 X-DKIM: Ecelerity dkim_sign implementing draft-ietf-dkim-base-00 DKIM-Signature: a=rsa-sha1; d=omniti.com; s=test; t=1192473106; c=simple/simple; q=dns; i=@omniti.com; h=From; b=T9M/JGY21fxiSQv+OIO1B8fqVc2UF8efyqXt4s04tL+YHZykfVWwILzWvg0rNT7b n4t6THXD0Fxm5b1tVNraT2zR2bpyZszMIGhsYs9WKtM/zrMumExhnK/+rljjGboW X-DomainKeys: Ecelerity dk_sign implementing draft-delany-domainkeys-base-01 DomainKey-Signature: q=dns; a=rsa-sha1; c=nofws; s=test; d=omniti.com; h=Authentication-Results:Received:In-Reply-To:References:Mime-Version:Content-Type:Message-Id:Cc:Content-Transfer-Encoding:From:Subject:Date:To:X-Mailer; b=Qn39k+KB+UTXy8TZuqgfUG2zLZiWM3ib+8n83AgZdsymdncA0vGmQKxVXQ0IE6fU Jn2zpTRrkPcaA78l5TZwg5j2zoV8ZjZn0pt8hVwygBYIjD5j/aBeeBbnxTJ4zrC3 Authentication-Results: mail.omniti.com smtp.user=wez; auth=pass (LOGIN) Received: from [66.80.117.2] ([66.80.117.2:57938] helo=[10.79.0.104]) by mail.omniti.com (ecelerity 2.1.1.12 r(14453)) with ESMTPSA (cipher=AES128-SHA) id B9/A1-25249-D02B3174 for ; Mon, 15 Oct 2007 14:31:46 -0400 In-Reply-To: <4713A637.7070100@zend.com> References: <64ED731E-CA44-498E-9AF9-C9B00037B863@omniti.com> <4713A637.7070100@zend.com> Mime-Version: 1.0 (Apple Message framework v752.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-ID: <0FF7924D-52E6-4B22-B494-6E252477B389@omniti.com> Cc: internals@lists.php.net Content-Transfer-Encoding: 7bit Date: Mon, 15 Oct 2007 14:31:40 -0400 To: Stanislav Malyshev X-Mailer: Apple Mail (2.752.3) Subject: Re: [PHP-DEV] Large file support for PHP From: wez@omniti.com (Wez Furlong) On Oct 15, 2007, at 1:41 PM, Stanislav Malyshev wrote: > I didn't dive yet too deep into the patch, but shouldn't it be > fixed on stream level and not function level? I.e. there are a lot > of functions using streams (including files) - would they support > bigger files too? Yes, the patch does that; it turns on LFS in the headers, which promotes the off_t and size_t types that are used by streams to the 64-bit versions. This is the one liner in configure.in. The other larger part of the patch is to make PHP functions capable of returning and accepting numbers that are too big to fit into a long. > I also think that while using size_t is good, changing binary > structures might be rather dangerous, unless we can ensure all PHPs > built on the certain platform would use the same setting. That's why 5.3 is a good point to apply this patch, rather than sneaking it into 5.2.x --Wez.