Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:32783 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 71756 invoked by uid 1010); 15 Oct 2007 17:41:17 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 71741 invoked from network); 15 Oct 2007 17:41:17 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 Oct 2007 17:41:17 -0000 Authentication-Results: pb1.pair.com header.from=stas@zend.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=stas@zend.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender) X-PHP-List-Original-Sender: stas@zend.com X-Host-Fingerprint: 212.25.124.162 mail.zend.com Windows 2000 SP4, XP SP1 Received: from [212.25.124.162] ([212.25.124.162:47002] helo=mx1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 02/AF-39149-C36A3174 for ; Mon, 15 Oct 2007 13:41:17 -0400 Received: from us-ex1.zend.com ([192.168.16.5]) by mx1.zend.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 15 Oct 2007 19:41:14 +0200 Received: from [192.168.16.91] ([192.168.16.91]) by us-ex1.zend.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 15 Oct 2007 10:41:10 -0700 Message-ID: <4713A637.7070100@zend.com> Date: Mon, 15 Oct 2007 10:41:11 -0700 Organization: Zend Technologies User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Wez Furlong CC: internals@lists.php.net References: <64ED731E-CA44-498E-9AF9-C9B00037B863@omniti.com> In-Reply-To: <64ED731E-CA44-498E-9AF9-C9B00037B863@omniti.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 15 Oct 2007 17:41:10.0436 (UTC) FILETIME=[92C7C640:01C80F52] Subject: Re: [PHP-DEV] Large file support for PHP From: stas@zend.com (Stanislav Malyshev) I didn't dive yet too deep into the patch, but shouldn't it be fixed on stream level and not function level? I.e. there are a lot of functions using streams (including files) - would they support bigger files too? I also think that while using size_t is good, changing binary structures might be rather dangerous, unless we can ensure all PHPs built on the certain platform would use the same setting. > Having run into this issue recently, here's a patch (hopefully attached, > mail.app and list filters willing) against PHP 5.3 to address it. > This patch will promote to double the file sizes that overflow LONG_MAX, > which works transparently for my script. > Note that this only touches the obvious functions in the core; there may > be other extensions that need to behave similarly. > > The defines that I jam into CFLAGS are known to work in our other > projects on Linux, Solaris, FreeBSD and OSX. The other (weirder) > platforms might need some other adjustments to work correctly. > > --Wez. > -- Stanislav Malyshev, Zend Software Architect stas@zend.com http://www.zend.com/ (408)253-8829 MSN: stas@zend.com