Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:32769
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain seanius.net from 66.93.22.232 cause and error)
To: internals@lists.php.net
Date: Mon, 15 Oct 2007 08:27:12 +0200
User-Agent: KMail/1.9.7
Cc: Wez Furlong <wez@omniti.com>
References: <64ED731E-CA44-498E-9AF9-C9B00037B863@omniti.com>
In-Reply-To: <64ED731E-CA44-498E-9AF9-C9B00037B863@omniti.com>
MIME-Version: 1.0
Content-Type: multipart/signed;
  boundary="nextPart6314143.4hmrkzmShH";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit
Message-ID: <200710150827.16765.seanius@seanius.net>
Subject: Re: [PHP-DEV] Large file support for PHP
From: seanius@seanius.net (sean finney)

--nextPart6314143.4hmrkzmShH
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

hi,

some non-php-dev comments in case they're helpful...

On Monday 15 October 2007 12:13:50 am Wez Furlong wrote:
> This bug has been open for a while:
> http://bugs.php.net/bug.php?id=3D27792

> Having run into this issue recently, here's a patch (hopefully
> attached, mail.app and list filters willing) against PHP 5.3 to
> address it.

using size_t/off_t is always good

> This patch will promote to double the file sizes that overflow
> LONG_MAX, which works transparently for my script.
> Note that this only touches the obvious functions in the core; there
> may be other extensions that need to behave similarly.

why not just use SIZE_MAX, and not have to worry about anything bigger?  I=
=20
can't profess to fully understand what's going on, but it looks like the=20
functions are being converted from returning a long to returning either a=20
long or a double, and then the result is parsed as a string???

> The defines that I jam into CFLAGS are known to work in our other
> projects on Linux, Solaris, FreeBSD and OSX.  The other (weirder)
> platforms might need some other adjustments to work correctly.

"getconf LFS_CFLAGS", assuming "getconf" exists...



	sean



--nextPart6314143.4hmrkzmShH
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBHEwhEynjLPm522B0RAirEAJ4kdGGAn5eZa4NhDtmorl5G6CAIBwCghkdz
8DeetD8jVAAeCR2Mx0xFAeY=
=f6ib
-----END PGP SIGNATURE-----

--nextPart6314143.4hmrkzmShH--