Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:32650
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain wayne.edu from 141.217.1.108 cause and error)
Message-ID: <4706454A.2060508@wayne.edu>
Date: Fri, 05 Oct 2007 10:08:10 -0400
Organization: Wayne State University
User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728)
MIME-Version: 1.0
To: Antony Dovgal <tony@daylessday.org>
CC: internals@lists.php.net
References: <4705E338.4020707@wayne.edu> <4705E72B.3080708@daylessday.org>
In-Reply-To: <4705E72B.3080708@daylessday.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Patch for bug# 41822
From: ab5602@wayne.edu (Rob Thompson)


Hi Antony,

Antony Dovgal wrote:

> Rob, I believe you're looking into wrong place.
> You should be patching virtual_file_ex() in TSRM/tsrm_virtual_cwd.c, the root of 
> all evils is there as this function is used by expand_filepath() and in all other places.

Ok, originally was going to try that, but, virtual_file_ex() is being
truthful in this case and correctly returning false and an empty cwd when:

   state->cwd_length == 0

..which is exactly what getcwd() is returning.  I'm thinking that
changing the tsrm_virtual_cwd code, or even the expand_filepath()
functions to fake a filepath, even with an #ifdef SOLARIS may not be
good style.  I don't know though, I'm still learning here.

> Also, as you might have noticed, we do not use system calls like open() directly, we use VCWD_xxx() wrappers for that.
> They are defined in TSRM/ either.

The use of the open() function was lifted right from later on in the
function call where the FD for the stream is normally created.  Is this
something that needs to be fixed too?

Thanks,
-Rob