Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:32644
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain daylessday.org designates 89.208.40.236 as permitted sender)
Message-ID: <4705E72B.3080708@daylessday.org>
Date: Fri, 05 Oct 2007 11:26:35 +0400
User-Agent: Thunderbird 2.0.0.6 (X11/20070801)
MIME-Version: 1.0
To: Rob Thompson <ab5602@wayne.edu>
CC:  internals@lists.php.net
References: <4705E338.4020707@wayne.edu>
In-Reply-To: <4705E338.4020707@wayne.edu>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Patch for bug# 41822
From: tony@daylessday.org (Antony Dovgal)

On 05.10.2007 11:09, Rob Thompson wrote:
> Here is a patch for bug 41822.  The expand_filepath() function will not
> work in Solaris if a non-root user attempts to read a file under a
> directory with only (--x) permissions.
> 
> Currently expand_path() returns NULL and no FD is opened, although the
> file is readable.  This patch adds a last-ditch effort to open includes
> using a relative path and returns NULL if it still can't get a file
> descriptor.

Rob, I believe you're looking into wrong place.
You should be patching virtual_file_ex() in TSRM/tsrm_virtual_cwd.c, the root of 
all evils is there as this function is used by expand_filepath() and in all other places.

Also, as you might have noticed, we do not use system calls like open() directly, we use VCWD_xxx() wrappers for that.
They are defined in TSRM/ either.

-- 
Wbr, 
Antony Dovgal