Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:32539 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 48782 invoked by uid 1010); 2 Oct 2007 11:06:43 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 48767 invoked from network); 2 Oct 2007 11:06:43 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Oct 2007 11:06:43 -0000 Authentication-Results: pb1.pair.com header.from=jani.taskinen@sci.fi; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=jani.taskinen@sci.fi; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain sci.fi from 63.208.196.171 cause and error) X-PHP-List-Original-Sender: jani.taskinen@sci.fi X-Host-Fingerprint: 63.208.196.171 outbound.mailhop.org FreeBSD 4.6-4.9 Received: from [63.208.196.171] ([63.208.196.171:2795] helo=outbound.mailhop.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 3D/90-42782-14622074 for ; Tue, 02 Oct 2007 07:06:41 -0400 Received: from pc128.sanomamagazines.fi ([194.211.146.128] helo=[10.26.8.44]) by outbound.mailhop.org with esmtpsa (SSLv3:RC4-MD5:128) (Exim 4.68) (envelope-from ) id 1IcfaI-000531-Vg; Tue, 02 Oct 2007 07:06:39 -0400 X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 194.211.146.128 X-Report-Abuse-To: abuse@dyndns.com (see http://www.mailhop.org/outbound/abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19WoRZKSZ6V9cf++wf740LEyAEypxupi6c= Reply-To: jani.taskinen@iki.fi To: Marcus Boerger Cc: David Soria Parra , internals@lists.php.net In-Reply-To: <926543049.20071002112624@marcus-boerger.de> References: <6E.76.20520.35861074@pb1.pair.com> <926543049.20071002112624@marcus-boerger.de> Content-Type: text/plain Date: Tue, 02 Oct 2007 14:06:39 +0300 Message-ID: <1191323199.3323.5.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.8.3 (2.8.3-2.fc6) Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] Proposal for fixing bug #40501 From: jani.taskinen@sci.fi (Jani Taskinen) I recommend AFTER. I myself tend to fix ws automatically..and then later trying to commit ws/cs fixes separately is PITA. So first fix the real problem then fix any ws/cs. :) --Jani On Tue, 2007-10-02 at 11:26 +0200, Marcus Boerger wrote: > Hello David, > > Monday, October 1, 2007, 11:36:19 PM, you wrote: > > > Hi internals, > > > once again a proposal for a bugfix. > > This time concerning http://bugs.php.net/bug.php?id=40501. > > > As the standard escape character is \\ , but the RFC says ", I added a > > optional escape character to the function call as a last parameter. > > Furthermore, when the escape character is the same as the enclosure > > character (e.g. "), a "" string will be escape, while a single " will be > > enclosured. > > > the patch and the according updated and added testfiles can be found at > > > http://experimentalworks.net/downloads/bug40501.patch.tar.gz > > > opinions? > > > greets > > David > > > Looks fine to me. And thanks for remembering to change SPL as well. > While I looked at your patch I noticed that white space in your patch was > not correct but in fact it looks like white space in all of SPL seems > broken. So we should either fix WS before or after that patch. > > Best regards, > Marcus > -- Patches/Donations: http://pecl.php.net/~jani/