Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:32536
Return-Path: <helly@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 14740 invoked by uid 1010); 2 Oct 2007 09:26:31 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 14725 invoked from network); 2 Oct 2007 09:26:31 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 2 Oct 2007 09:26:31 -0000
Authentication-Results: pb1.pair.com smtp.mail=helly@php.net; spf=unknown; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=helly@php.net; sender-id=unknown
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.94.56 as permitted sender)
X-PHP-List-Original-Sender: helly@php.net
X-Host-Fingerprint: 85.214.94.56 aixcept.net Linux 2.6
Received: from [85.214.94.56] ([85.214.94.56:35598] helo=h1149922.serverkompetenz.net)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 24/8A-20520-5CE02074 for <internals@lists.php.net>; Tue, 02 Oct 2007 05:26:30 -0400
Received: from dhcp-172-28-204-225.zrh.corp.google.com (unknown [193.142.125.1])
	(using TLSv1 with cipher AES256-SHA (256/256 bits))
	(No client certificate requested)
	by h1149922.serverkompetenz.net (Postfix) with ESMTP id 716601B361F;
	Tue,  2 Oct 2007 11:26:26 +0200 (CEST)
Date: Tue, 2 Oct 2007 11:26:24 +0200
Reply-To: Marcus Boerger <helly@php.net>
X-Priority: 3 (Normal)
Message-ID: <926543049.20071002112624@marcus-boerger.de>
To: David Soria Parra <dsp@php.net>
CC: internals@lists.php.net
In-Reply-To: <6E.76.20520.35861074@pb1.pair.com>
References: <6E.76.20520.35861074@pb1.pair.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] Proposal for fixing bug #40501
From: helly@php.net (Marcus Boerger)

Hello David,

Monday, October 1, 2007, 11:36:19 PM, you wrote:

> Hi internals,

> once again a proposal for a bugfix. 
> This time concerning http://bugs.php.net/bug.php?id=40501.

> As the standard escape character is \\ , but the RFC says ", I added a
> optional escape character to the function call as a last parameter.
> Furthermore, when the escape character is the same as the enclosure
> character (e.g. "), a "" string will be escape, while a single " will be
> enclosured.

> the patch and the according updated and added testfiles can be found at

> http://experimentalworks.net/downloads/bug40501.patch.tar.gz

> opinions?

> greets
>  David


Looks fine to me. And thanks for remembering to change SPL as well.
While I looked at your patch I noticed that white space in your patch was
not correct but in fact it looks like white space in all of SPL seems
broken. So we should either fix WS before or after that patch.

Best regards,
 Marcus