Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:32301 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 75958 invoked by uid 1010); 12 Sep 2007 18:05:21 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 75943 invoked from network); 12 Sep 2007 18:05:21 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 12 Sep 2007 18:05:21 -0000 Authentication-Results: pb1.pair.com smtp.mail=robert@interjinn.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=robert@interjinn.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain interjinn.com from 66.11.173.122 cause and error) X-PHP-List-Original-Sender: robert@interjinn.com X-Host-Fingerprint: 66.11.173.122 unknown Linux 2.5 (sometimes 2.4) (4) Received: from [66.11.173.122] ([66.11.173.122:53749] helo=blobule.interjinn.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 2A/51-00780-C5A28E64 for ; Wed, 12 Sep 2007 14:05:18 -0400 Received: by blobule.interjinn.com (Postfix, from userid 2000) id 315FF22449C; Wed, 12 Sep 2007 14:05:12 -0400 (EDT) To: Andrew Shearer Cc: Marcus Boerger , internals@lists.php.net In-Reply-To: <17c19be0709121053u617071beq8d420926f60db46f@mail.gmail.com> References: <27DA5A7A-276C-480F-A75C-7F64BB38316B@ashearer.com> <142319111.20070911112759@marcus-boerger.de> <1262949578.20070911172112@marcus-boerger.de> <17c19be0709110933m537df263pfae99322b8ae0b32@mail.gmail.com> <702402878.20070911185402@marcus-boerger.de> <1189531022.30041.88.camel@blobule> <421016323.20070912101332@marcus-boerger.de> <17c19be0709121053u617071beq8d420926f60db46f@mail.gmail.com> Content-Type: text/plain Content-Transfer-Encoding: 7bit Organization: InterJinn Date: Wed, 12 Sep 2007 14:05:12 -0400 Message-ID: <1189620312.30041.182.camel@blobule> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Subject: Re: [PHP-DEV] [PATCH] array_get() From: robert@interjinn.com (Robert Cummings) On Wed, 2007-09-12 at 13:53 -0400, Andrew Shearer wrote: > > > Here is the patch and unit test file for array_get(): > > http://ashearer.com/software/array_get/2007-09-10-php6/array_get.diff > http://ashearer.com/software/array_get/2007-09-10-php6/array_get.phpt > > > And here is the backward compatibility function: > > if (!function_exists('array_get')) { > function array_get($arr, $key, $default = false) { > if (array_key_exists($key, $arr)) { > return $arr[$key]; > } > else { > return $default; > } > } > } IMHO the default value for $default should be null. That way it has the same return value as using an undefined index on an array. Comments? Cheers, Rob. -- ........................................................... SwarmBuy.com - http://www.swarmbuy.com Leveraging the buying power of the masses! ...........................................................