Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:32184 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 9202 invoked by uid 1010); 10 Sep 2007 12:58:49 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 9187 invoked from network); 10 Sep 2007 12:58:49 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Sep 2007 12:58:49 -0000 Authentication-Results: pb1.pair.com header.from=tokul@users.sourceforge.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=tokul@users.sourceforge.net; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain users.sourceforge.net from 213.197.162.99 cause and error) X-PHP-List-Original-Sender: tokul@users.sourceforge.net X-Host-Fingerprint: 213.197.162.99 avilys.eik.lt Linux 2.6 Received: from [213.197.162.99] ([213.197.162.99:49778] helo=avilys.eik.lt) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 49/F0-01533-78F35E64 for ; Mon, 10 Sep 2007 08:58:49 -0400 Received: from avilys.eik.lt (avilys.local [127.0.0.1]) by avilys.eik.lt (Postfix) with ESMTP id CAC401F5166; Mon, 10 Sep 2007 15:52:13 +0300 (EEST) Received: from avilys.eik.lt (avilys.local [127.0.0.1]) by avilys.eik.lt (Postfix) with ESMTP id A7C5F1F5165; Mon, 10 Sep 2007 15:52:13 +0300 (EEST) Received: from 195.22.180.233 (NaSMail authenticated user tomas@topolis.lt) by avilys.eik.lt with HTTP; Mon, 10 Sep 2007 15:52:13 +0300 (EEST) Message-ID: <39089.195.22.180.233.1189428733.squirrel@avilys.eik.lt> In-Reply-To: <1164605984.20070910144547@marcus-boerger.de> References: <60461.195.22.180.233.1188818194.squirrel@avilys.eik.lt> <1188820136.3317.3.camel@localhost.localdomain> <46392.195.22.180.233.1189075177.squirrel@avilys.eik.lt> <1164605984.20070910144547@marcus-boerger.de> Date: Mon, 10 Sep 2007 15:52:13 +0300 (EEST) To: "Marcus Boerger" Cc: internals@lists.php.net User-Agent: NaSMail/1.2 MIME-Version: 1.0 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-Virus-Scanned: ClamAV using ClamSMTP Subject: Re: [PHP-DEV] PHP bugs in Turkish locale From: tokul@users.sourceforge.net ("Tomas Kuliavas") > when developing a patch like this, it is more readable to do typical > min max notation to ease readability. That is change: > if (91 > i && i > 64) { > To: > if (64 < i && i < 91) { > > the real issue here is that if we fix it this way we break other locales. How they break? Do you want to support case insensitive 8bit method and class names in other locales? If fix breaks other locales, then you are already breaking them on Windows with _tolower_l() function. My test shows that only strcasecmp is affected. Other PHP case insensitive string functions remain LC_CTYPE aware. -- Tomas