Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:32181 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 927 invoked by uid 1010); 10 Sep 2007 12:46:03 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 898 invoked from network); 10 Sep 2007 12:46:03 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Sep 2007 12:46:03 -0000 Authentication-Results: pb1.pair.com smtp.mail=helly@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=helly@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.94.56 as permitted sender) X-PHP-List-Original-Sender: helly@php.net X-Host-Fingerprint: 85.214.94.56 aixcept.net Linux 2.6 Received: from [85.214.94.56] ([85.214.94.56:35788] helo=h1149922.serverkompetenz.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 75/FB-19032-98C35E64 for ; Mon, 10 Sep 2007 08:46:02 -0400 Received: from dhcp-172-28-204-149.zrh.corp.google.com (unknown [193.142.125.1]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by h1149922.serverkompetenz.net (Postfix) with ESMTP id 583A41B3622; Mon, 10 Sep 2007 14:45:48 +0200 (CEST) Date: Mon, 10 Sep 2007 14:45:47 +0200 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <1164605984.20070910144547@marcus-boerger.de> To: "Tomas Kuliavas" CC: jani.taskinen@iki.fi, internals@lists.php.net In-Reply-To: <46392.195.22.180.233.1189075177.squirrel@avilys.eik.lt> References: <60461.195.22.180.233.1188818194.squirrel@avilys.eik.lt> <1188820136.3317.3.camel@localhost.localdomain> <46392.195.22.180.233.1189075177.squirrel@avilys.eik.lt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] PHP bugs in Turkish locale From: helly@php.net (Marcus Boerger) Hello Tomas, when developing a patch like this, it is more readable to do typical min max notation to ease readability. That is change: if (91 > i && i > 64) { To: if (64 < i && i < 91) { the real issue here is that if we fix it this way we break other locales. marcus Thursday, September 6, 2007, 12:39:37 PM, you wrote: > I can't add comments on that bug report. > http://www.topolis.lt/php/#35050 > Here comes the patch. Only strcasecmp results are affected. I suspect that > PHP scripts and interpreter itself use same strcasecmp function. >> You are free to send a patch.. >> >> If you have objections, please add comment to the report marked as "Wont >> fix" and don't spam the already huge database with one more report about >> same issue. >> >> --Jani >> >> >> On Mon, 2007-09-03 at 14:16 +0300, Tomas Kuliavas wrote: >>> Hi, >>> >>> Maybe somebody could provide good explanation why you can fix the issue >>> (http://bugs.php.net/bug.php?id=42526). You can't claim that locale >>> insensitive tolower() breaks things, because your functions are locale >>> insensitive in some setups. >>> >>> Now I can only see that PHP developers close bug reports as "bogus" or >>> "won't fix" without any good explanation. I think I've already said on >>> this list once. If you lie in order to prove your point, you lose. You >>> don't need PHP6 in order to fix it. Fix is possible or I don't see whole >>> picture. >>> >>> -- >>> Tomas Best regards, Marcus