Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:32089 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 46192 invoked by uid 1010); 7 Sep 2007 07:09:25 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 46177 invoked from network); 7 Sep 2007 07:09:25 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Sep 2007 07:09:25 -0000 Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.94.239.5 as permitted sender) X-PHP-List-Original-Sender: derick@php.net X-Host-Fingerprint: 82.94.239.5 jdi.jdi-ict.nl Linux 2.6 Received: from [82.94.239.5] ([82.94.239.5:34668] helo=jdi.jdi-ict.nl) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 30/A4-14206-229F0E64 for ; Fri, 07 Sep 2007 03:09:24 -0400 Received: from localhost (localhost [127.0.0.1]) by jdi.jdi-ict.nl (8.13.7/8.12.11) with ESMTP id l8779IW7007667; Fri, 7 Sep 2007 09:09:19 +0200 Date: Fri, 7 Sep 2007 09:09:18 +0200 (CEST) X-X-Sender: derick@kossu.ez.no To: Andi Gutmans cc: David Wang , Marcus Boerger , Nuno Lopes , internals@lists.php.net, andi@php.net, dmitry@php.net In-Reply-To: <698DE66518E7CA45812BD18E807866CEA2A93C@us-ex1.zend.net> Message-ID: References: <20070904162613.4qgfdddo7scw8o8w@w13.mail.sapo.pt> <849426349.20070904210047@marcus-boerger.de> <698DE66518E7CA45812BD18E807866CEA2A93C@us-ex1.zend.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=UTF-8 Subject: RE: [PHP-DEV] Patch for macros for tracking refcount and is_ref From: derick@php.net (Derick Rethans) On Thu, 6 Sep 2007, Andi Gutmans wrote: > In general the patch is fine. > The only thing which I'd like to change is to make sure the __gc naming > is in an #if ZEND_GC for now otherwise we'll be breaking lots of third > party libraries and PECL extensions. But you might want to wonder if that's not a good thing? Without the prefix there will be no indication for third party extensions that they might be doing something that's not going to work nicely with the new GC anymore. I'd prefer it to have the __gc always there. Derick -- Derick Rethans http://derickrethans.nl | http://ez.no | http://xdebug.org