Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:32084 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 80992 invoked by uid 1010); 7 Sep 2007 00:39:14 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 80976 invoked from network); 7 Sep 2007 00:39:14 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Sep 2007 00:39:14 -0000 Authentication-Results: pb1.pair.com header.from=andi@zend.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=andi@zend.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 63.205.162.114 as permitted sender) X-PHP-List-Original-Sender: andi@zend.com X-Host-Fingerprint: 63.205.162.114 unknown Windows 2000 SP4, XP SP1 Received: from [63.205.162.114] ([63.205.162.114:58719] helo=us-ex1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F3/56-46127-0BD90E64 for ; Thu, 06 Sep 2007 20:39:13 -0400 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Date: Thu, 6 Sep 2007 17:39:09 -0700 Message-ID: <698DE66518E7CA45812BD18E807866CEA2A93C@us-ex1.zend.net> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PHP-DEV] Patch for macros for tracking refcount and is_ref Thread-Index: AcfwSVZwxGih3bdhSf+SuW+HwnYUEAAngWCQ References: <20070904162613.4qgfdddo7scw8o8w@w13.mail.sapo.pt> <849426349.20070904210047@marcus-boerger.de> To: "David Wang" , "Marcus Boerger" Cc: "Nuno Lopes" , , , Subject: RE: [PHP-DEV] Patch for macros for tracking refcount and is_ref From: andi@zend.com ("Andi Gutmans") Hi David, In general the patch is fine. The only thing which I'd like to change is to make sure the __gc naming is in an #if ZEND_GC for now otherwise we'll be breaking lots of third party libraries and PECL extensions. Andi > -----Original Message----- > From: David Wang [mailto:planetbeing@gmail.com] > Sent: Wednesday, September 05, 2007 10:47 PM > To: Marcus Boerger > Cc: Nuno Lopes; internals@lists.php.net; andi@php.net; dmitry@php.net > Subject: Re: [PHP-DEV] Patch for macros for tracking refcount and > is_ref >=20 > > In my own code, I have a "__gc" on refcount and is_ref so I get > thrown > > an error if there's a place I failed to macroize. I removed that for > > this patch, but that's a very good point. If there are no objections, > > that or another prefix or suffix can be put back into the patch. >=20 > I've posted another version of the patch with the __gc suffix at > http://zoo.cs.yale.edu/~yw226/macros2.diff.txt >=20 > The GC patch is also ready. As soon as the macros patch has been > finalized and committed, I will send that out to the mailing list. >=20 > David