Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:32077
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain mysql.com from 213.136.52.68 cause and error)
Message-ID: <46DFB940.7040600@mysql.com>
Date: Thu, 06 Sep 2007 10:24:32 +0200
Organization: MySQL AB
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.9) Gecko/20061211 SeaMonkey/1.0.7
MIME-Version: 1.0
To: BuildSmart <buildsmart@daleenterprise.com>
CC: PHP Developers Mailing List <internals@lists.php.net>,
        Rasmus Lerdorf <rasmus@lerdorf.com>
References: <CCA533C4-E8E2-4F77-99CD-FDB9ECC5E2EA@daleenterprise.com> <46DF60BF.9090805@lerdorf.com> <5430305D-28D0-48C6-8A21-4E711CF21311@daleenterprise.com>
In-Reply-To: <5430305D-28D0-48C6-8A21-4E711CF21311@daleenterprise.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] proof of concept or undocumented?
From: hartmut@mysql.com (Hartmut Holzgraefe)

BuildSmart wrote:

> The only differences I could find was that openssl was enabled in the=20
> working builds but not enabled in the failing build.
>=20
[...]
> I went a step further and manually added the ssl libraries (-lssl=20
> -lcrypto) to the Makefile (both as bundled and shared) and all worked w=
ell.
>=20
> This cannot be considered a bug (or maybe it is), perhaps an additional=
=20
> check could/should be performed to see if mysql is built with SSL=20
> support and if so check whether openssl is enabled and add the ssl=20
> libraries to the sapi build or to MYSQL_SHARED_LDADD if it's not or to =

> auto-enable openssl?

yes, ext/mysql is not too clever about this and simply relies
on ext/openssl being enabled at the same time.

Adding an extra test can't rely on mysql_config though as AFAIR
it is not using mysql_config at all.

If you want to check whether you'd need to add a compile/link
test with a small example program that tries to e.g. use

   http://dev.mysql.com/doc/refman/4.1/en/mysql-ssl-set.html

I'm not sure though whether this function is only available
with ssl-enabled MySQL builds or whether it is always there
and just returning error codes, i think it is the later so
you'd have to create a functionality test, not just a simple
"does it compile and link without errors" one.

As this is not a change to the actual functionality of ext/mysql
i think a working patch would be accepted even though the
extension is deprecated by now. OTOH i don't really think it
is worth the effort anymore though ...

--=20
Hartmut Holzgraefe, Principal Support Engineer
               .
Discover new MySQL Monitoring & Advisory features at:
http://www.mysql.com/products/enterprise/whats_new.html

Hauptsitz: MySQL GmbH, Dachauer Str.37, 80335 M=FCnchen
Gesch=E4ftsf=FChrer: Kaj Arn=F6 - HRB M=FCnchen 162140