Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:32059
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.182.185 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=ha5LL4Oau3ra3RDyuM4LW7KqTd17lkgdq1QUzIx4WEagTfswJtAmvKghhlriyHRRvxQG5lynvzXXCIBAFgd0+y5QpiScbgizb2cCOZhT+RafAfSI79aGK49jEESPzEqgAP4UQeu0bIHJTYZmJR4xiv7dQaA3qE6/X2MljRY3G2U=
Message-ID: <ee59b7580709041919s2dbacb69pda3cfa6517f7e2d3@mail.gmail.com>
Date: Wed, 5 Sep 2007 10:19:05 +0800
To: "Marcus Boerger" <helly@php.net>
Cc: "Nuno Lopes" <nlopess@php.net>, internals@lists.php.net, andi@php.net, 
	dmitry@php.net
In-Reply-To: <849426349.20070904210047@marcus-boerger.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <ee59b7580709040724y23427c4bq2f6cd3b2ee409276@mail.gmail.com>
	 <20070904162613.4qgfdddo7scw8o8w@w13.mail.sapo.pt>
	 <ee59b7580709040938t6bde9dd4na121b9a7b5cb3599@mail.gmail.com>
	 <849426349.20070904210047@marcus-boerger.de>
Subject: Re: [PHP-DEV] Patch for macros for tracking refcount and is_ref
From: planetbeing@gmail.com ("David Wang")

On 9/5/07, Marcus Boerger <helly@php.net> wrote:
> What is the problem with those objects? Basically there are at least three
> seperated memory areas involved. First the zend_object container, the real
> object and one or several zvals. The gc would simply have to decrease
> refcount on zend_objects if their zval gets down to zero and then leave
> zend_object gc'ing to the object storage.

Hmm, maybe we have a misunderstanding here because I don't quite
understand what you mean. :) In that paragraph, I was saying how
implementing a traditional tracing garbage collector would mean
refcounts are no longer necessary. These macros track refcounts, so
they would also be no longer necessary.

> Question for development, how do we ensure that starting from a specific
> point in time we enforce usage of those macros? The one thing that comes
> into my mind is that we could have the members [is_ref,refcount] prefixed
> with something different when running in debug mode, or insert some random
> prefix there....(?)

In my own code, I have a "__gc" on refcount and is_ref so I get thrown
an error if there's a place I failed to macroize. I removed that for
this patch, but that's a very good point. If there are no objections,
that or another prefix or suffix can be put back into the patch.

David