Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:32038
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 212.55.154.22 as permitted sender)
Message-ID: <20070904172420.2yftwh0cg000kw0s@w13.mail.sapo.pt>
Date: Tue, 04 Sep 2007 17:24:20 +0100
To: David Wang <planetbeing@gmail.com>
Cc: internals@lists.php.net, andi@php.net, dmitry@php.net
References: <ee59b7580709040724y23427c4bq2f6cd3b2ee409276@mail.gmail.com>
	<20070904162613.4qgfdddo7scw8o8w@w13.mail.sapo.pt>
	<ee59b7580709040835v65705d05y39563122d36ec738@mail.gmail.com>
In-Reply-To:  <ee59b7580709040835v65705d05y39563122d36ec738@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset=ISO-8859-15;
	DelSp="Yes";
	format="flowed"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
User-Agent: Internet Messaging Program (IMP) H3 (4.2-cvs)
Subject: Re:  Re: [PHP-DEV] Patch for macros for tracking refcount and
	is_ref
From: nlopess@php.net (Nuno Lopes)

>> About the patch, the zval_*_p() functions don't really need to exist..
>> they can be macros as well.
>
> As I said, if those were macros, it would be very difficult to squeeze
> more than one statement into them.
>
> Having multiple statements in Z_DELREF_P will also break that code. It
> seems to me inline functions are the best solution (the second best
> solution would be to put braces around the statements in the define,
> but then no return value would be possible).

currently you only have one statement in each of those functions..
anyway it's not critical to have static inline functions.


>> (and the online keyword is also handled by
>> the Zend engine)
>
> Do you mean ZEND_VM_ALWAYS_INLINE? There is a ZEND_VM_ALWAYS_INLINE
> #define that does something similar to my "always_inline". However, it
> doesn't work for Microsoft compilers, and since it doesn't include the
> "inline" keyword within its definition, I'd have to change the meaning
> of it in order to fix that. As far as I can tell, it's not referenced
> by any code at all, but that still might be a bad idea.

nops. The Zend engine redefines the inline keyword itself somewhere.

Nuno